Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix anglescan when the two molecules are different #458

Merged
merged 4 commits into from
Oct 31, 2024
Merged

Conversation

mlund
Copy link
Owner

@mlund mlund commented Oct 29, 2024

Anglescan would wrongly assume that both molecules are the same. @IVinterbladh could you verify that the bug is fixed?

@mlund mlund added the bug 🐛 Broken or wrong functionality label Oct 29, 2024
@mlund mlund requested a review from IVinterbladh October 29, 2024 18:56
@@ -119,7 +124,7 @@ void AngularScan::operator()(Space& spc, Energy::Hamiltonian& hamiltonian)

#pragma omp parallel for
for (const auto& q1 : angles.quaternions_1) {
auto particles1 = molecules.second.getRotatedReference(spc.groups, q1);
auto particles1 = molecules.first.getRotatedReference(spc.groups, q1);
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Source of the problem!

@mlund mlund changed the title Fix anglescan for hetero molecules Fix anglescan when the two molecules are different Oct 29, 2024
Copy link
Collaborator

@IVinterbladh IVinterbladh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is tested and now it works using two different particles for the anglescan method. The anglescan correctly distinguishes the two particles.

@mlund mlund merged commit 84063d2 into master Oct 31, 2024
3 checks passed
@mlund mlund deleted the anglescan-fix branch October 31, 2024 21:57
@mlund mlund restored the anglescan-fix branch October 31, 2024 21:57
@mlund mlund deleted the anglescan-fix branch October 31, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Broken or wrong functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants