Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use optional integer to store exchange partner #455

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

mlund
Copy link
Owner

@mlund mlund commented Jul 19, 2024

This should have the exact same output but with slightly better code readability / safety since the non-value -1 is replaced with an optional structure.

mlund added 2 commits July 19, 2024 10:17
This uses an optional integer to represent exchange MPI rank.
@mlund mlund added the code quality ⚙️ Code refactoring / restructuring label Jul 19, 2024
@mlund mlund requested a review from IVinterbladh July 19, 2024 08:44
Copy link
Collaborator

@IVinterbladh IVinterbladh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@IVinterbladh IVinterbladh merged commit ed4dc6a into master Jul 19, 2024
3 checks passed
@IVinterbladh IVinterbladh deleted the optional_exchange branch July 19, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality ⚙️ Code refactoring / restructuring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants