Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default predict_type to crank for all learners #299

Closed
RaphaelS1 opened this issue Nov 25, 2022 · 4 comments
Closed

Set default predict_type to crank for all learners #299

RaphaelS1 opened this issue Nov 25, 2022 · 4 comments

Comments

@RaphaelS1
Copy link
Collaborator

https://github.com/RaphaelS1/proba_benchmark/issues/38
@bblodfon
Copy link
Collaborator

bblodfon commented Dec 4, 2023

@RaphaelS1 I don't remember why we had set thip up - is very easy to do, maybe just harmoning default options?

@RaphaelS1
Copy link
Collaborator Author

It's because of a clash with the GraphLearner interface. Yes just harmonising (not sure which don't have this as default anyway TBH)

@bblodfon bblodfon mentioned this issue Dec 10, 2023
Merged
@bblodfon
Copy link
Collaborator

It was CoxPH only here, for mlr3extralearners I will open an issue there

@bblodfon bblodfon mentioned this issue Dec 10, 2023
Closed
@bblodfon
Copy link
Collaborator

All mlr3proba learners (surv.coxph, surv.rpart, surv.kaplan) have now crank as default predict_type so we can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bblodfon @RaphaelS1