Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't pass additional arguments via more.args to simple filter #2709

Closed
annette987 opened this issue Jan 8, 2020 · 1 comment · Fixed by #2712
Closed

Can't pass additional arguments via more.args to simple filter #2709

annette987 opened this issue Jan 8, 2020 · 1 comment · Fixed by #2712
Labels

Comments

@annette987
Copy link

annette987 commented Jan 8, 2020

After recent changes to filters (#2693) it is no longer possible to pass additional arguments to a simple filter via more.args:

library(survival)
library(mlr)
#> Loading required package: ParamHelpers
#> 'mlr' is in maintenance mode since July 2019. Future development
#> efforts will go into its successor 'mlr3' (<https://mlr3.mlr-org.com>).

set.seed(24601)
data(veteran)
mas.task <- makeSurvTask(id = "VET", data = veteran, target = c("time", "status"))
outer = makeResampleDesc("CV", iters = 2, stratify = TRUE)

cox.filt.mindepth.lrn = makeFilterWrapper(
    makeLearner(cl = "surv.coxph", id = "cox.filt.mindepth", predict.type = "response"), 
    fw.method = "randomForestSRC_var.select",
    fw.abs = 5,
    more.args = list("metho" = "md", ntree=100, nsplit = 10, nodesize = 3)
  )

learners = list(cox.filt.mindepth.lrn)   
bmr = benchmark(learners, mas.task, outer, show.info = TRUE)
#> Task: VET, Learner: cox.filt.mindepth.filtered
#> Resampling: cross-validation
#> Measures:             cindex
#> Error in generate.fv.data(task = task, method = method, nselect = getTaskNFeats(task), : Assertion on 'more.args' failed: Must have length <= 1, but has length 4.

Created on 2020-01-08 by the reprex package (v0.3.0)

I can submit a PR to fix this.

@pat-s
Copy link
Member

pat-s commented Jan 8, 2020

PR welcome! Thanks for asking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants