Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

h2o.deeplearning early stopping: stopping_rounds is missing? #2658

Closed
albersonmiranda opened this issue Oct 21, 2019 · 3 comments · Fixed by #2668
Closed

h2o.deeplearning early stopping: stopping_rounds is missing? #2658

albersonmiranda opened this issue Oct 21, 2019 · 3 comments · Fixed by #2668
Labels
project - Learners type-enhancement

Comments

@albersonmiranda
Copy link
Contributor

albersonmiranda commented Oct 21, 2019 •
edited
Loading

Doesn't seems to be stopping_rounds in getParamSet("classif.h2o.deeplearning").
I'm aware of classification_stop but it's not the same.
Am i missing something here?
@pat-s
Copy link
Member

pat-s commented Oct 21, 2019

Haven't checked right now but it could very well be that a param is missing for a learner. You are welcome to open a PR which adds it 👍

@jakob-r
Copy link
Member

jakob-r commented Oct 23, 2019

It suprises me, that it is present for regr.h2o.deeplearning. Was there any reason to not include it for classif.h2o.deeplearning? @Coorsaa
This is also true for other parameters as stopping_metric, max_runtime_secs and stopping_tolerance.
Also does it make sense that regression_stop is defined for classif.h2o.deeplearning?

@albersonmiranda
Copy link
Contributor Author

albersonmiranda commented Oct 27, 2019 •
edited by jakob-r
Loading

Added PR: #2668

@albersonmiranda albersonmiranda mentioned this issue Nov 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
project - Learners type-enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update RLearner_classif_h2odeeplearning.R
3 participants
@jakob-r @pat-s @albersonmiranda