From d7c93b398ae42a242d46be5e97ad38ce9826c196 Mon Sep 17 00:00:00 2001 From: Jakob Richter Date: Thu, 10 Aug 2017 15:07:02 +0300 Subject: [PATCH] Enabling github templates for Issues and PRs (#1893) --- .github/ISSUE_TEMPLATE.md | 43 ++++++++++++++++++++++++++++++++ .github/PULL_REQUEST_TEMPLATE.md | 14 +++++++++++ 2 files changed, 57 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE.md create mode 100644 .github/PULL_REQUEST_TEMPLATE.md diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md new file mode 100644 index 0000000000..a2c93eea55 --- /dev/null +++ b/.github/ISSUE_TEMPLATE.md @@ -0,0 +1,43 @@ +For bug reports, please respect the following guidelines and check the boxes accordingly. +Please include your source code using tripple backticks ` like this: + + +```r +# your code +``` + + +For questions of the type: "How can this be done?", please consider posting them on Stackoverflow. + +For everything else ignore this template. + +## Bug report + +- [ ] Start a new R session +- [ ] Install the latest version of mlr: `update.packages(oldPkgs="mlr", ask=FALSE)` or if you use a GitHub install of mlr: `devtools::install_github(c("BBmisc", "ParamHelpers", "mlr"))` +- [ ] run `sessionInfo()` +- [ ] Give a minimal reproducible example + +## Writing a good bug report + +[ Slightly adapted version of (this) [https://www.r-project.org/bugs.html#writing-a-good-bug-report] ] + +Bug reports should include a way of reproducing the bug. This should be as simple as possible. If the person trying to fix the bug can’t work out how to make it appear, or has to jump through a lot of unnecessary hoops to make it appear, you’re going to waste a lot of their time. + +mlr is maintained by a number of people, so it’s best to make sure your bug report is clear and well-written. If it’s not, it will suck in more energy from the maintainers and take longer for the bug to get fixed - or it may end up not getting handled at all. In particular, you should: + +Write a clear and unique summary for the bug. “Running a model on data set with a constant feature causes the following exception” is good; “software crashes” is not. +Include, in the description, the steps to reproduce the bug mentioned above. +Focus most on the facts of what happened, but if course helps if you can already give us (informed!) guesses where the bug comes from. + +## Minimal reproducible example + +A minimal reproducible example consists of the following items: + +a minimal dataset, necessary to reproduce the error +the minimal runnable code necessary to reproduce the error, which can be run on the given dataset. +the necessary information on the used packages, R version and system it is run on. +in the case of random processes, a seed (set by set.seed()) for reproducibility + +If you want to learn more, read +https://stackoverflow.com/questions/5963269/how-to-make-a-great-r-reproducible-example] diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 0000000000..6b53571218 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,14 @@ +We are always happy to receive pull requests. + +Please make sure you have read our coding guidelines: +https://github.com/mlr-org/mlr/wiki/mlr-Coding-Guidelines + +This especially means that you have understood: + +* The style guide - our lintr will provide you feedback on this +* How to run tests locally. Yes, travis will also run them for you, bad it is annoying to wait for this. +* How to run R CMD CHECK locally. See point before. + +Also it's helpful to get into direct contact with the suggested reviewers to get help, getting your PR merged. +You might want to join our slack at: +https://mlr-org.slack.com