Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JOSS] Docker installation #11

Closed
edeno opened this issue May 19, 2023 · 6 comments
Closed

[JOSS] Docker installation #11

edeno opened this issue May 19, 2023 · 6 comments

Comments

@edeno
Copy link

edeno commented May 19, 2023

It would be great to document what a user should do after running the docker image. For example, I tried:

root@05b17dd067c8:/# ipython
Python 3.9.14 (main, Oct  5 2022, 15:22:07) 
Type 'copyright', 'credits' or 'license' for more information
IPython 8.11.0 -- An enhanced Interactive Python. Type '?' for help.

In [1]: import deepof
---------------------------------------------------------------------------
ModuleNotFoundError                       Traceback (most recent call last)
Cell In[1], line 1
----> 1 import deepof

ModuleNotFoundError: No module named 'deepof'

xref: openjournals/joss-reviews#5394

@lucasmiranda42
Copy link
Collaborator

Thank you for trying all installation methods! Indeed, one must install DeepOF after loading the docker image (either using pip or from the repo). Would you recommend editing the documentation, or adding DeepOF to the Docker image directly?

@edeno
Copy link
Author

edeno commented May 19, 2023

I would add DeepOF to the docker image directly. Might as well cut down on an additional step for the user.

@lucasmiranda42
Copy link
Collaborator

Perfect. Building already. Should be up in an hour or so

@lucasmiranda42
Copy link
Collaborator

Dear @edeno,

I just pushed an updated Docker image with DeepOF loaded onto it, which should address the problem presented above. I'll close this issue for now, but feel free to reopen if needed, of course!

@edeno
Copy link
Author

edeno commented May 22, 2023

Okay I was able to import deepof successfully in this docker container. One question for you is would it also be beneficial to have deeplabcut in the container as well since the two libraries are dependent or is that out of scope in your mind?

@lucasmiranda42
Copy link
Collaborator

Glad it worked! Thank you for the suggestion. While I'm happy to discuss it further if you think it's necessary, I'm not a big fan of the idea, mainly because there are many different versions of DeepLabCut that are compatible with DeepOF, and users may prefer one over the other for some particular reason. Besides, DLC provides its own set of Docker images already, so setting up two independent environments would be the most versatile. Hope this helps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants