Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mlem for iPad #251

Closed
NathanielIR opened this issue Jul 10, 2023 · 4 comments
Closed

Mlem for iPad #251

NathanielIR opened this issue Jul 10, 2023 · 4 comments
Assignees
Milestone

Comments

@NathanielIR
Copy link

NathanielIR commented Jul 10, 2023

G'day @tht7 ! I've been using the iPad version and here are all the issues I've found and things that could probably be changed (I'll likely find more in the future and update this):

For the record, I am running iPadOS 17 Developer Beta 3

  • I know this isn't necessarily a very common use on iPadOS but when you have a magic mouse or trackpad connected, swiping right on a comment doesn't show voting controls as expected but instead opens the side bar.
  • I think the dock should be a part of the side bar at the top, rather than seperate at the bottom
  • On the "Feeds" page, there are two sidebars and the side bar button opens the "Accounts" page which personally I don't think it particularly important. But on for instance, the "Settings" tab, the side bar button closes the side bar for the settings menu. But then when you're on the "Feeds" page in portrait, the side bar is the "Communities" page and there's a back button to get to your accounts.
  • When in portrait with the "Communities" side bar open, the alphabet swipey thing is awkwardly small and in the middle
  • When haptic touching on a comment, there is no background (for the comment)
  • When scrolling through the Communities sidebar the translucent bar at the top that shows the letter that you're looking at doesn't cover the entire side bar but instead stops before the edge
  • When haptic touching on a comment on the inbox page, you can see upvote and read buttons behind the comment on the edges
  • The entire search tab is inside the side bar with absolutely nothing on the right
  • When haptic touching on a post on the feeds page, you can see a box outside of the solid box for the comment
  • There is a lot of wasted space in web links if you turn on "Show website icons"
  • In the search tab, if you disable the side bar, rescale the window to a size that doesn't have a sidebar, and then go back to a size that does, the sidebar button disappears. Furthermore, sometimes, when you re enable the side bar, the actual search bar disappears until you swipe/scroll down on it
  • If you scale the window to a size that supports the sidebar but doesn't support the sidebar next to content (the sidebar covers the content) and then open the sidebar in the feeds tab, if you tab back (to see your accounts), there is no way to disable the accounts tab without closing both sidebars entirely.
  • Right-clicking/Haptic touching on a community in the sidebar doesn't do anything. It would be nice if it let you unsubscribe or block the community or open the "Sidebar" (not the iPad one) for that community
  • If you open a post without the sidebar (meaning the post is taking up the entire display such as in the inbox), the time since posted icon is awkwardly sitting in the middle of the screen
  • (Suggestion) the inbox tab should have a sidebar and tapping on a post/reply should show it on the right
  • (Suggestion) the sidebar for communities should be an actual sidebar on the right-hand side
  • (Suggestion) the upvote/downvote/etc buttons should have outlines when you hover over them with a mouse/trackpad. Not 100% sure if this is possible with the way that they've been built though
  • The enter button on a physical keyboard when writing a post just deselects the text field rather than going down a line
  • I feel like when scaling the app horizontally, it decides that I can't permanently have a sidebar a little too soon

Added later:

  • when you swipe to vote/reply, if you move it a veeeerryyy little bit back and forth in the middle of the slider, the colours flash a bit behind the content
  • (Suggestion) I love the new post design with separation between the posts. It would be awesome to see it on iOS!
  • When the app is scaled to a size that uses the sidebar but doesn’t show it permanently and the app is in dark mode, the colours for the icons darken a lot and look rather out of place
@NathanielIR
Copy link
Author

@tht7 added 3 more items

@EricBAndrews EricBAndrews added this to the Future milestone Jul 16, 2023
@EricBAndrews
Copy link
Member

Child of #105

@EricBAndrews EricBAndrews moved this from To Triage to Backlog in Development Tracker Jul 16, 2023
@NathanielIR
Copy link
Author

Thanks @EricBAndrews! I was talking to tht7 on Lemmy and he asked me to find some bugs and assign the issue to him but for some reason it wouldn’t let me (I assume I don’t have the permission)

@Sjmarf
Copy link
Member

Sjmarf commented Dec 17, 2024

Closing this as too broad. I've split the remaining points into individual issues (#1514, #1515, #1516, #1517).

I know this isn't necessarily a very common use on iPadOS but when you have a magic mouse or trackpad connected, swiping right on a comment doesn't show voting controls as expected but instead opens the side bar.

#1514

I think the dock should be a part of the side bar at the top, rather than separate at the bottom

#1515

On the "Feeds" page, there are two sidebars and the side bar button opens the "Accounts" page which personally I don't think it particularly important. But on for instance, the "Settings" tab, the side bar button closes the side bar for the settings menu. But then when you're on the "Feeds" page in portrait, the side bar is the "Communities" page and there's a back button to get to your accounts.

We've moved away from this design.

When in portrait with the "Communities" side bar open, the alphabet swipey thing is awkwardly small and in the middle.

We've hidden this on iPad in 2.0.

When haptic touching on a comment, there is no background (for the comment)

Fixed

When scrolling through the Communities sidebar the translucent bar at the top that shows the letter that you're looking at doesn't cover the entire side bar but instead stops before the edge

Fixed

When haptic touching on a comment on the inbox page, you can see upvote and read buttons behind the comment on the edges

Fixed

The entire search tab is inside the side bar with absolutely nothing on the right

Fixed

When haptic touching on a post on the feeds page, you can see a box outside of the solid box for the comment

Fixed

There is a lot of wasted space in web links if you turn on "Show website icons"

Fixed, I think.

In the search tab, if you disable the side bar, rescale the window to a size that doesn't have a sidebar, and then go back to a size that does, the sidebar button disappears. Furthermore, sometimes, when you re enable the side bar, the actual search bar disappears until you swipe/scroll down on it

Probably fixed; we rewrote the entire search tab code.

If you scale the window to a size that supports the sidebar but doesn't support the sidebar next to content (the sidebar covers the content) and then open the sidebar in the feeds tab, if you tab back (to see your accounts), there is no way to disable the accounts tab without closing both sidebars entirely.

Fixed; we don't use the three-column system anymore.

Right-clicking/Haptic touching on a community in the sidebar doesn't do anything. It would be nice if it let you unsubscribe or block the community or open the "Sidebar" (not the iPad one) for that community

Fixed.

If you open a post without the sidebar (meaning the post is taking up the entire display such as in the inbox), the time since posted icon is awkwardly sitting in the middle of the screen

Yeah, some of the post layouts are awkwardly large on iPad. One way to fix this is #1150; if anyone has got any otber ideas feel free to open an issue.

(Suggestion) the inbox tab should have a sidebar and tapping on a post/reply should show it on the right

I think integrating the inbox into the existing sidebar (as in #1515) is a better solution than this.

(Suggestion) the sidebar for communities should be an actual sidebar on the right-hand side

#1516

(Suggestion) the upvote/downvote/etc buttons should have outlines when you hover over them with a mouse/trackpad. Not 100% sure if this is possible with the way that they've been built though

#1517

The enter button on a physical keyboard when writing a post just deselects the text field rather than going down a line

Fixed

I feel like when scaling the app horizontally, it decides that I can't permanently have a sidebar a little too soon

I don't think we have control over this; it's a system thing.

when you swipe to vote/reply, if you move it a veeeerryyy little bit back and forth in the middle of the slider, the colours flash a bit behind the content

Probably fixed; we wrote the swipe action system.

When the app is scaled to a size that uses the sidebar but doesn’t show it permanently and the app is in dark mode, the colours for the icons darken a lot and look rather out of place

Fixed

@Sjmarf Sjmarf closed this as not planned Won't fix, can't repro, duplicate, stale Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Backlog
Development

No branches or pull requests

4 participants