Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve EntityEvent fields #333

Merged
merged 10 commits into from
Jan 16, 2024
Merged

Improve EntityEvent fields #333

merged 10 commits into from
Jan 16, 2024

Conversation

mlange-42
Copy link
Owner

@mlange-42 mlange-42 commented Jan 15, 2024

  • Pass events by value/copy instead of by pointer. It torned out heap escape is much more expensive than copying.
  • Removes event fields that are accessible from the world.
  • Adds event fields to better identify relation changes.
  • Reduces the size of EntityEvent by 30%.

* remove event fields that are accessible from the world
* add event fields to better identify relation changes
@mlange-42 mlange-42 added the usability Usability and ergonomics label Jan 15, 2024
@mlange-42 mlange-42 self-assigned this Jan 15, 2024
@coveralls
Copy link
Collaborator

coveralls commented Jan 15, 2024

Pull Request Test Coverage Report for Build 7533551176

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 7528343499: 0.0%
Covered Lines: 4989
Relevant Lines: 4989

💛 - Coveralls

@mlange-42 mlange-42 marked this pull request as draft January 16, 2024 00:02
@mlange-42 mlange-42 changed the title Improve EntityEvent Improve EntityEvent fields Jan 16, 2024
@mlange-42 mlange-42 marked this pull request as ready for review January 16, 2024 08:32
@mlange-42 mlange-42 merged commit 9db71a4 into main Jan 16, 2024
13 checks passed
@mlange-42 mlange-42 deleted the simplify-events branch January 16, 2024 08:34
@mlange-42 mlange-42 added the breaking change Marks API breaking changes label Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Marks API breaking changes usability Usability and ergonomics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants