Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Univeral sentence encoder] Ports tfjs Univeral sentence encoder model #790

Merged
merged 11 commits into from
Apr 8, 2020

Conversation

joeyklee
Copy link
Contributor

Dear ml5 community,

I'm making a Pull Request(PR). Please see the details below.

A good PR 🌟

β†’ Step 1: Which branch are you submitting to? 🌲

Development (for new features or updates), Release (for bug fixes), or ___________?

  • development

β†’ Step 2: Describe your Pull Request πŸ“

Fixing a Bug? Adding an Update? Submitting a New Feature? Does it introduce a breaking change?

A great PR 🌟🌟

β†’ Step 3: Share a Relevant Example πŸ¦„

Here's some example code or a link to another PR in https://github.com/ml5js/ml5-examples OR in the https://editor.p5js.org or codepen/jsfiddle/etc...

src/UniversalSentenceEncoder/index.js Show resolved Hide resolved
src/UniversalSentenceEncoder/index.js Outdated Show resolved Hide resolved
@joeyklee
Copy link
Contributor Author

Hi @bomanimc!

For simplicity, let's do it this way:

  1. Re: [Universal sentence encoder] Adds example for Universal Sentence EncoderΒ ml5-examples#262 (comment) - Let's merge the PR for this feature and the PR for the example now.
  2. We can refine and update once the m5-examples and library merge is complete.
  3. We can leave it undocumented until we feel it is ready for more public usage and once we have some more examples showcasing how it works, but for simplicity of devOps, I think it is ok to merge.

@joeyklee
Copy link
Contributor Author

joeyklee commented Apr 8, 2020

Hi All - I think this is ready to go. @bomanimc I will merge this in for now. We can refine the examples to make them a bit friendlier as we see fit. Thanks @henrmota for your reviews earlier on -- they were very helpful! πŸ™

@joeyklee joeyklee merged commit dad91c9 into development Apr 8, 2020
@joeyklee joeyklee deleted the univeral-sentence-encoder branch May 24, 2020 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants