Scheduler: fix OffLoadingInvoker

- ScheduledInvoker#invoke() should never return null
mkouba · Nov 6, 2024 · 81c9a0f · 81c9a0f
1 parent 4865eae
commit 81c9a0f
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 19 deletions.
diff --git a/...ler/common/src/main/java/io/quarkus/scheduler/common/runtime/DelayedExecutionInvoker.java b/...ler/common/src/main/java/io/quarkus/scheduler/common/runtime/DelayedExecutionInvoker.java
@@ -53,12 +53,7 @@ public CompletionStage<Void> invoke(ScheduledExecution execution) throws Excepti
         executor.schedule(new Runnable() {
             @Override
             public void run() {
-                try {
-                    delegate.invoke(execution);
-                    ret.complete(null);
-                } catch (Exception e) {
-                    ret.completeExceptionally(e);
-                }
+                invokeComplete(ret, execution);
             }
         }, delay, TimeUnit.MILLISECONDS);
         return ret;

diff --git a/...s/scheduler/common/src/main/java/io/quarkus/scheduler/common/runtime/DelegateInvoker.java b/...s/scheduler/common/src/main/java/io/quarkus/scheduler/common/runtime/DelegateInvoker.java
@@ -2,6 +2,7 @@
 
 import java.util.concurrent.CompletableFuture;
 import java.util.concurrent.CompletionStage;
+import java.util.function.BiConsumer;
 
 import io.quarkus.scheduler.ScheduledExecution;
 
@@ -30,4 +31,17 @@ protected CompletionStage<Void> invokeDelegate(ScheduledExecution execution) {
             return CompletableFuture.failedStage(e);
         }
     }
+
+    protected void invokeComplete(CompletableFuture<Void> ret, ScheduledExecution execution) {
+        invokeDelegate(execution).whenComplete(new BiConsumer<>() {
+            @Override
+            public void accept(Void r, Throwable t) {
+                if (t != null) {
+                    ret.completeExceptionally(t);
+                } else {
+                    ret.complete(null);
+                }
+            }
+        });
+    }
 }
diff --git a/...scheduler/common/src/main/java/io/quarkus/scheduler/common/runtime/OffloadingInvoker.java b/...scheduler/common/src/main/java/io/quarkus/scheduler/common/runtime/OffloadingInvoker.java
@@ -1,6 +1,7 @@
 package io.quarkus.scheduler.common.runtime;
 
 import java.util.concurrent.Callable;
+import java.util.concurrent.CompletableFuture;
 import java.util.concurrent.CompletionStage;
 
 import io.quarkus.scheduler.ScheduledExecution;
@@ -28,6 +29,7 @@ public OffloadingInvoker(ScheduledInvoker delegate, Vertx vertx) {
 
     @Override
     public CompletionStage<Void> invoke(ScheduledExecution execution) throws Exception {
+        CompletableFuture<Void> ret = new CompletableFuture<>();
         Context context = VertxContext.getOrCreateDuplicatedContext(vertx);
         VertxContextSafetyToggle.setContextSafe(context, true);
         if (delegate.isBlocking()) {
@@ -40,7 +42,7 @@ public void handle(Void event) {
                         VirtualThreadsRecorder.getCurrent().execute(new Runnable() {
                             @Override
                             public void run() {
-                                doInvoke(execution);
+                                invokeComplete(ret, execution);
                             }
                         });
                     }
@@ -49,7 +51,7 @@ public void run() {
                 context.executeBlocking(new Callable<Void>() {
                     @Override
                     public Void call() {
-                        doInvoke(execution);
+                        invokeComplete(ret, execution);
                         return null;
                     }
                 }, false);
@@ -58,19 +60,11 @@ public Void call() {
             context.runOnContext(new Handler<Void>() {
                 @Override
                 public void handle(Void event) {
-                    doInvoke(execution);
+                    invokeComplete(ret, execution);
                 }
             });
         }
-        return null;
-    }
-
-    void doInvoke(ScheduledExecution execution) {
-        try {
-            delegate.invoke(execution);
-        } catch (Throwable t) {
-            // already logged by the StatusEmitterInvoker
-        }
+        return ret;
     }
 
 }
diff --git a/.../scheduler/common/src/main/java/io/quarkus/scheduler/common/runtime/ScheduledInvoker.java b/.../scheduler/common/src/main/java/io/quarkus/scheduler/common/runtime/ScheduledInvoker.java
@@ -11,7 +11,7 @@ public interface ScheduledInvoker {
 
     /**
      * @param execution
-     * @return the result
+     * @return the result, never {@code null}
      * @throws Exception
      */
     CompletionStage<Void> invoke(ScheduledExecution execution) throws Exception;