Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inliner task #31

Open
mklabs opened this issue Apr 21, 2012 · 0 comments
Open

inliner task #31

mklabs opened this issue Apr 21, 2012 · 0 comments

Comments

@mklabs
Copy link
Owner

mklabs commented Apr 21, 2012

Just found out about https://github.com/remy/inliner is a fantastic package, we should use it, or at least take inspiration from.

  • have a super nice api ->eventemitter.
  • build a list of all assets used
    • all inline images and base64 encode
    • all external style sheets
    • all image references in CSS
  • even supports css inlining (we now do this through rjs)
  • can convert img as based64 data urls in both html and css
  • inline scripts / styles

It does however a few thing that we likely already do.

  • a bit of feature overlapping
  • relies on jsdom, so that will be a pain for windows user

It can also be the main handler for the dom-based build. Also thinking of playing with substack/node-trumpet to rely on a streaming html parser and remove the need of jsdom or cheerio.

@mklabs mklabs mentioned this issue Apr 21, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant