Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write margin in lowercase in styles #1619

Closed
hteumeuleu opened this issue Jun 17, 2019 · 2 comments
Closed

Write margin in lowercase in styles #1619

hteumeuleu opened this issue Jun 17, 2019 · 2 comments

Comments

@hteumeuleu
Copy link

Certain components (like mjml-section or mjml-button) generate Margin styles with an uppercase M.

This was useful historically for Outlook.com where CSS support depended on case. So margin:0 would get stripped by Outlook.com, but not Margin:0;. This is no longer the case (no pun intended) since the last versions of Outlook.com so it can be safely changed back to lowercase margin everywhere. This might be a small thing but it can be one less quirk to figure out for newcomers and make MJML look more up to date towards modern best practices.

See this bug report for more details.

@Ryan-Zell
Copy link
Contributor

Some companies have clients working on older systems. Having backwards compatibility is a good thing in my opinion. Outlook has the capability to parse between the two.

@hteumeuleu
Copy link
Author

Are you sure about that? My understanding was that every Outlook.com accounts were migrated to the new Office 365 type of accounts. Also there’s been two successive versions of Outlook.com where this bug has no longer been there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants