Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .ExternalClass rules in reset styles #1614

Closed
hteumeuleu opened this issue Jun 13, 2019 · 2 comments
Closed

Remove .ExternalClass rules in reset styles #1614

hteumeuleu opened this issue Jun 13, 2019 · 2 comments

Comments

@hteumeuleu
Copy link

In the HTML code generated by MJML, the first <style> tag contains the following rules :

.ExternalClass {
   width: 100%;
}

.ExternalClass * {
    line-height: 100%;
}

This was useful for Outlook.com up to circa 2016. The new versions of Outlook.com since 2016 no longer use the .ExternalClass prefix.

These styles should be safely removed from the generated HTML.

@iRyusa iRyusa added this to the 4.4 milestone Jun 13, 2019
@iRyusa
Copy link
Member

iRyusa commented Jun 13, 2019

Hey !

Let's add that change for the next 4.4 beta then. 👍

Thanks !

@hteumeuleu
Copy link
Author

After a bit more research, looks like the .ReadMsgBody selector in the reset styles also relate to older Outlook.com versions and no longer apply. So this can be safely removed as well:

.ReadMsgBody {
   width: 100%;
}

(See also this thread for a discussion on these selectors.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants