From 816e38fda6d35c860fca1a4a3cf6ca99830f5991 Mon Sep 17 00:00:00 2001
From: meriadec <meriadec.pillet@gmail.com>
Date: Sat, 10 Jun 2017 12:21:55 +0200
Subject: [PATCH] Replace `openItem` by `openExternal` to try to make it work
 on osx

related to #146
---
 app/actions/queryLastVersion.js    | 2 +-
 app/components/ErrorModal/index.js | 2 +-
 app/components/Iframe/index.js     | 2 +-
 app/menu.js                        | 4 ++--
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/app/actions/queryLastVersion.js b/app/actions/queryLastVersion.js
index aa2efa14..bbc9f2b2 100644
--- a/app/actions/queryLastVersion.js
+++ b/app/actions/queryLastVersion.js
@@ -41,7 +41,7 @@ export default function queryLastVersion () {
             primary
             className='mt-20'
             onClick={() => {
-              shell.openItem(getDownloadURL())
+              shell.openExternal(getDownloadURL())
             }}
           >
             <IconDownload className='mr-5' />
diff --git a/app/components/ErrorModal/index.js b/app/components/ErrorModal/index.js
index 7715d730..a51c7c55 100644
--- a/app/components/ErrorModal/index.js
+++ b/app/components/ErrorModal/index.js
@@ -78,7 +78,7 @@ class ErrorModal extends Component {
           <pre>{stack}</pre>
         </div>
         <div className='d-f ai-c jc-c'>
-          <Button primary onClick={() => shell.openItem('https://github.com/mjmlio/mjml-app/issues')}>
+          <Button primary onClick={() => shell.openExternal('https://github.com/mjmlio/mjml-app/issues')}>
             <IconOpen className='mr-5' />
             {'Open the issues page'}
           </Button>
diff --git a/app/components/Iframe/index.js b/app/components/Iframe/index.js
index 0f61f946..a009ac7a 100644
--- a/app/components/Iframe/index.js
+++ b/app/components/Iframe/index.js
@@ -48,7 +48,7 @@ class Iframe extends Component {
             e.preventDefault()
             const href = link.getAttribute('href')
             if (href) {
-              shell.openItem(href)
+              shell.openExternal(href)
             }
           })
         })
diff --git a/app/menu.js b/app/menu.js
index 939079ad..e2d4df2d 100644
--- a/app/menu.js
+++ b/app/menu.js
@@ -24,12 +24,12 @@ export default function buildMenu (mainWindow) {
       }, {
         label: 'Documentation',
         click () {
-          shell.openItem('https://mjml.io/documentation/')
+          shell.openExternal('https://mjml.io/documentation/')
         },
       }, {
         label: 'Browser Editor',
         click () {
-          shell.openItem('https://mjml.io/try-it-live')
+          shell.openExternal('https://mjml.io/try-it-live')
         },
       }, {
         type: 'separator',