Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments and Ratings #4

Closed
mjakeman opened this issue Jan 11, 2022 · 3 comments · Fixed by #100
Closed

Comments and Ratings #4

mjakeman opened this issue Jan 11, 2022 · 3 comments · Fixed by #100
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@mjakeman
Copy link
Owner

The user should be able to view comments and extension ratings as part of the search results.

Displaying the comments will be quite tricky. We need a way to either render HTML or (ideally) convert it to Pango markup.

Investigate whether there is a way to display simple HTML markup without using webkit.

@mjakeman mjakeman added enhancement New feature or request help wanted Extra attention is needed labels Jan 11, 2022
@mjakeman mjakeman modified the milestone: 0.2.0 Jan 12, 2022
@mjakeman mjakeman mentioned this issue Jan 14, 2022
7 tasks
@mjakeman mjakeman added this to the 0.3.0 milestone Jan 29, 2022
@mjakeman
Copy link
Owner Author

mjakeman commented Feb 1, 2022

An update on the status of this issue.

  • All of the web-related work to retrieve comment data is implemented in the web-refactor branch (needs a rebase).
  • The main issue now involves displaying an HTML subset
  • I am working on a rich text component that will hopefully support both display and editing of rich text
  • Is there an opportunity to use this inside extension-manager?
  • Furthermore, can we collaborate with upstream extensions-web to allow authoring comments in-app?
    • This would require authentication support
    • Can we benefit from librest?

@mjakeman
Copy link
Owner Author

mjakeman commented Feb 5, 2022

As of PR mjakeman/text-engine#3, my rich text component now supports enough of HTML to display comments from extensions.gnome.org. Comments and reviews will therefore be part of the 0.3 release 🥳.

As a quick demonstration, the following messy HTML snippet:

<p>There was an Old Man with a beard\nWho said, &quot;It is just as I feared!</p><p> &gt; Two Owls and a Hen,<br> &gt; Four Larks and a Wren,</p><p>Have all built their nests in my beard!&quot;</p>

Is successfully rendered as follows, with support for wrap-around if necessary.

image

@mjakeman
Copy link
Owner Author

mjakeman commented Feb 5, 2022

Work-in-progress support for comments:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant