media: platform: allegro-dvt: Fix possible memory leak in allocate_bu…

…ffers_internal() The buffer in the loop should be released under the exception path, otherwise there may be a memory leak here. To mitigate this, free the buffer when allegro_alloc_buffer fails. Fixes: f20387d ("media: allegro: add Allegro DVT video IP core driver") Cc: <[email protected]> Signed-off-by: Gaosheng Cui <[email protected]> Signed-off-by: Hans Verkuil <[email protected]>
mj22226 · Oct 12, 2024 · 0f51406 · 0f51406
1 parent 869f38a
commit 0f51406
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/drivers/media/platform/allegro-dvt/allegro-core.c b/drivers/media/platform/allegro-dvt/allegro-core.c
@@ -1509,8 +1509,10 @@ static int allocate_buffers_internal(struct allegro_channel *channel,
 		INIT_LIST_HEAD(&buffer->head);
 
 		err = allegro_alloc_buffer(dev, buffer, size);
-		if (err)
+		if (err) {
+			kfree(buffer);
 			goto err;
+		}
 		list_add(&buffer->head, list);
 	}