From 70ebab09dd3748bb4a2e89b9a133dedfa3db5f70 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Sch=C3=BCrmann?= <daschuer@mixxx.org>
Date: Wed, 1 Sep 2021 22:26:34 +0200
Subject: [PATCH] Silence warnings for expected invalid keys.

This fixes lp1942350 a regression from #4229
---
 src/control/control.cpp | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/control/control.cpp b/src/control/control.cpp
index d7d4db46d60..a19680e2a70 100644
--- a/src/control/control.cpp
+++ b/src/control/control.cpp
@@ -134,9 +134,11 @@ QSharedPointer<ControlDoublePrivate> ControlDoublePrivate::getControl(
         bool bPersist,
         double defaultValue) {
     if (!key.isValid()) {
-        qWarning() << "ControlDoublePrivate::getControl returning nullptr"
-                   << "for invalid ConfigKey" << key;
-        DEBUG_ASSERT(flags.testFlag(ControlFlag::AllowInvalidKey));
+        if (!flags.testFlag(ControlFlag::AllowInvalidKey)) {
+            qWarning() << "ControlDoublePrivate::getControl returning nullptr"
+                       << "for invalid ConfigKey" << key;
+            DEBUG_ASSERT(!"Unexpected invalid key");
+        }
         return nullptr;
     }