From 90b63fb59827f4cebae147432117ced41527fdb4 Mon Sep 17 00:00:00 2001 From: Jan Holthuis Date: Fri, 25 Sep 2020 22:40:25 +0200 Subject: [PATCH 1/2] engine/loopingcontrol: Fix precision loss (wrong use of int) --- src/engine/loopingcontrol.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/engine/loopingcontrol.cpp b/src/engine/loopingcontrol.cpp index adf9953968f..2a90532a5c6 100644 --- a/src/engine/loopingcontrol.cpp +++ b/src/engine/loopingcontrol.cpp @@ -613,7 +613,7 @@ void LoopingControl::setLoopOutToCurrentPosition() { BeatsPointer pBeats = m_pBeats; LoopSamples loopSamples = m_loopSamples.getValue(); double quantizedBeat = -1; - int pos = m_currentSample.getValue(); + double pos = m_currentSample.getValue(); if (m_pQuantizeEnabled->toBool() && pBeats) { if (m_bAdjustingLoopOut) { double closestBeat = m_pClosestBeat->get(); From d95394182897a837c33218ef7b6f3fc71b9105f5 Mon Sep 17 00:00:00 2001 From: Jan Holthuis Date: Sat, 26 Sep 2020 01:29:09 +0200 Subject: [PATCH 2/2] CHANGELOG: Add entry for double precision fixes (#3126, #3127) --- CHANGELOG | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG b/CHANGELOG index 2a7f7f4af2e..55521790367 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -4,6 +4,7 @@ * Add controller mapping for Hercules DJControl Jogvision #2370 * Fix missing manual in deb package lp:1889776 * Fix caching of duplicate tracks that reference the same file #3027 +* Fix loss of precision when dealing with floating-point sample positions while setting loop out position and seeking using vinyl control #3126 #3127 ==== 2.2.4 2020-05-10 ====