From 142f8297b5a55eb87e2b80283ccee90e9966fb53 Mon Sep 17 00:00:00 2001 From: ronso0 Date: Fri, 2 Nov 2018 19:20:09 +0100 Subject: [PATCH 1/3] repair [Channel2] xFader orientation button --- res/skins/LateNight/mixer.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/res/skins/LateNight/mixer.xml b/res/skins/LateNight/mixer.xml index f703f5f4089..cbeb9b2f54a 100644 --- a/res/skins/LateNight/mixer.xml +++ b/res/skins/LateNight/mixer.xml @@ -246,6 +246,7 @@ orientation + 34f,15f 3 0 From ac558453696fa2d788e06b308205aeb37f864282 Mon Sep 17 00:00:00 2001 From: ronso0 Date: Sat, 3 Nov 2018 18:11:27 +0100 Subject: [PATCH 2/3] deck xFader orientation: use button templates --- res/skins/LateNight/mixer.xml | 64 +++++--------------- res/skins/LateNight/mixer_channel_4decks.xml | 31 +++------- 2 files changed, 24 insertions(+), 71 deletions(-) diff --git a/res/skins/LateNight/mixer.xml b/res/skins/LateNight/mixer.xml index cbeb9b2f54a..c5299dcdfe1 100644 --- a/res/skins/LateNight/mixer.xml +++ b/res/skins/LateNight/mixer.xml @@ -169,30 +169,14 @@ min,me - - 34f,15f - orientation - 3 - - 0 - buttons/btn_orientation_deckLeft_left.svg - buttons/btn_orientation_deckLeft_left.svg - - - 1 - buttons/btn_orientation_deck_master.svg - buttons/btn_orientation_deck_master.svg - - - 2 - buttons/btn_orientation_deckLeft_right.svg - buttons/btn_orientation_deckLeft_right.svg - - - [Channel1],orientation - LeftButton - - + min,me @@ -244,30 +228,14 @@ min,me - - orientation - 34f,15f - 3 - - 0 - buttons/btn_orientation_deckRight_left.svg - buttons/btn_orientation_deckRight_left.svg - - - 1 - buttons/btn_orientation_deck_master.svg - buttons/btn_orientation_deck_master.svg - - - 2 - buttons/btn_orientation_deckRight_right.svg - buttons/btn_orientation_deckRight_right.svg - - - [Channel2],orientation - LeftButton - - + min,me diff --git a/res/skins/LateNight/mixer_channel_4decks.xml b/res/skins/LateNight/mixer_channel_4decks.xml index 5b5f31c5675..14ebaed6fe3 100644 --- a/res/skins/LateNight/mixer_channel_4decks.xml +++ b/res/skins/LateNight/mixer_channel_4decks.xml @@ -65,29 +65,14 @@ vertical min,min - - orientation - 3 - - 0 - buttons/btn_orientation_deck_left.svg - buttons/btn_orientation_deck_left.svg - - - 1 - buttons/btn_orientation_deck_master.svg - buttons/btn_orientation_deck_master.svg - - - 2 - buttons/btn_orientation_deck_right.svg - buttons/btn_orientation_deck_right.svg - - - ,orientation - LeftButton - - + From 931728f874c5059fbf5694e7818870471c71d2dc Mon Sep 17 00:00:00 2001 From: ronso0 Date: Sat, 3 Nov 2018 18:13:35 +0100 Subject: [PATCH 3/3] LateNight: use button templates (almost) everywhere, fix blurred beatgrid icons --- res/skins/LateNight/aux_unit.xml | 219 ++++++------------ res/skins/LateNight/button_2state_persist.xml | 41 ++++ res/skins/LateNight/button_3state.xml | 49 ++++ res/skins/LateNight/button_3state_persist.xml | 48 ++++ .../LateNight/buttons/btn_quickEffect.svg | 1 + .../buttons/btn_quickEffect_down.svg | 1 + res/skins/LateNight/deck_row_1_keyVinylFx.xml | 134 ++++------- res/skins/LateNight/mic_aux_rack.xml | 40 +--- res/skins/LateNight/mic_unit.xml | 212 +++++------------ .../LateNight/mixer_master_headphone.xml | 132 ++++------- .../LateNight/quick_effect_knob_4decks.xml | 25 +- .../LateNight/quick_effect_knob_left.xml | 25 +- .../LateNight/quick_effect_knob_right.xml | 25 +- res/skins/LateNight/rate_controls.xml | 101 +++----- res/skins/LateNight/toolbar.xml | 129 ++++------- res/skins/LateNight/vinyl_controls.xml | 126 +++------- res/skins/LateNight/waveform.xml | 123 +++++----- res/skins/LateNight/waveforms.xml | 19 +- 18 files changed, 561 insertions(+), 889 deletions(-) create mode 100644 res/skins/LateNight/button_2state_persist.xml create mode 100644 res/skins/LateNight/button_3state.xml create mode 100644 res/skins/LateNight/button_3state_persist.xml create mode 100644 res/skins/LateNight/buttons/btn_quickEffect.svg create mode 100644 res/skins/LateNight/buttons/btn_quickEffect_down.svg diff --git a/res/skins/LateNight/aux_unit.xml b/res/skins/LateNight/aux_unit.xml index d005452e299..c2030b0adad 100644 --- a/res/skins/LateNight/aux_unit.xml +++ b/res/skins/LateNight/aux_unit.xml @@ -60,29 +60,14 @@ vertical min,max - - orientation - 3 - - 0 - buttons/btn_orientation_aux_left.svg - buttons/btn_orientation_aux_left.svg - - - 1 - buttons/btn_orientation_aux_master.svg - buttons/btn_orientation_aux_master.svg - - - 2 - buttons/btn_orientation_aux_right.svg - buttons/btn_orientation_aux_right.svg - - - ,orientation - LeftButton - - + @@ -145,24 +130,12 @@ - - pfl - MicPflButton - 2 - - 0 - buttons/btn_pfl_down.svg - buttons/btn_pfl.svg - - - 1 - buttons/btn_pfl_overdown.svg - buttons/btn_pfl_over.svg - - - ,pfl - - + @@ -172,43 +145,23 @@ horizontal min,min - - 35f,22f - EffectUnit_auxiliary_enabled - FxAssignButton - 2 - - 0 - FX 1 - - - 1 - FX 1 - - - [EffectRack1_EffectUnit1],group__enable - LeftButton - - - - - 35f,22f - EffectUnit_auxiliary_enabled - FxAssignButton - 2 - - 0 - FX 2 - - - 1 - FX 2 - - - [EffectRack1_EffectUnit2],group__enable - LeftButton - - + + + [Master],show_4effectunits @@ -222,81 +175,41 @@ horizontal min,min - - 30f,22f - EffectUnit_auxiliary_enabled - FxAssignButton - 2 - - 0 - FX 1 - - - 1 - FX 1 - - - [EffectRack1_EffectUnit1],group__enable - LeftButton - - - - - 20f,22f - EffectUnit_auxiliary_enabled - FxAssignButton - 2 - - 0 - 2 - - - 1 - 2 - - - [EffectRack1_EffectUnit2],group__enable - LeftButton - - - - - 20f,22f - EffectUnit_auxiliary_enabled - FxAssignButton - 2 - - 0 - 3 - - - 1 - 3 - - - [EffectRack1_EffectUnit3],group__enable - LeftButton - - - - - 20f,22f - EffectUnit_auxiliary_enabled - FxAssignButton - 2 - - 0 - 4 - - - 1 - 4 - - - [EffectRack1_EffectUnit4],group__enable - LeftButton - - + + + + + + + [Master],show_4effectunits diff --git a/res/skins/LateNight/button_2state_persist.xml b/res/skins/LateNight/button_2state_persist.xml new file mode 100644 index 00000000000..604ab0e897c --- /dev/null +++ b/res/skins/LateNight/button_2state_persist.xml @@ -0,0 +1,41 @@ + + diff --git a/res/skins/LateNight/button_3state.xml b/res/skins/LateNight/button_3state.xml new file mode 100644 index 00000000000..2448b8143c7 --- /dev/null +++ b/res/skins/LateNight/button_3state.xml @@ -0,0 +1,49 @@ + + diff --git a/res/skins/LateNight/button_3state_persist.xml b/res/skins/LateNight/button_3state_persist.xml new file mode 100644 index 00000000000..2e234d31797 --- /dev/null +++ b/res/skins/LateNight/button_3state_persist.xml @@ -0,0 +1,48 @@ + + diff --git a/res/skins/LateNight/buttons/btn_quickEffect.svg b/res/skins/LateNight/buttons/btn_quickEffect.svg new file mode 100644 index 00000000000..2fb3fac4f69 --- /dev/null +++ b/res/skins/LateNight/buttons/btn_quickEffect.svg @@ -0,0 +1 @@ + diff --git a/res/skins/LateNight/buttons/btn_quickEffect_down.svg b/res/skins/LateNight/buttons/btn_quickEffect_down.svg new file mode 100644 index 00000000000..2f53f316f00 --- /dev/null +++ b/res/skins/LateNight/buttons/btn_quickEffect_down.svg @@ -0,0 +1 @@ + diff --git a/res/skins/LateNight/deck_row_1_keyVinylFx.xml b/res/skins/LateNight/deck_row_1_keyVinylFx.xml index 19fb4f21cd2..959e914850a 100644 --- a/res/skins/LateNight/deck_row_1_keyVinylFx.xml +++ b/res/skins/LateNight/deck_row_1_keyVinylFx.xml @@ -62,97 +62,57 @@ horizontal - AlignRightTop - + AlignRightTop + - - - 28f,22f - EffectUnit_deck_enabled - FxAssignButton - 2 - - 0 - FX 1 - - - 1 - FX 1 - - - [EffectRack1_EffectUnit1],group__enable - LeftButton - - + + - - 28f,22f - EffectUnit_deck_enabled - FxAssignButton - 2 - - 0 - FX 2 - - - 1 - FX 2 - - - [EffectRack1_EffectUnit2],group__enable - LeftButton - - + - - horizontal - - [Master],show_4effectunits - visible - - - - 28f,22f - EffectUnit_deck_enabled - FxAssignButton - 2 - - 0 - FX 3 - - - 1 - FX 3 - - - [EffectRack1_EffectUnit3],group__enable - LeftButton - - + + horizontal + + [Master],show_4effectunits + visible + + + - - 28f,22f - EffectUnit_deck_enabled - FxAssignButton - 2 - - 0 - FX 4 - - - 1 - FX 4 - - - [EffectRack1_EffectUnit4],group__enable - LeftButton - - - - - - - + + + + + + diff --git a/res/skins/LateNight/mic_aux_rack.xml b/res/skins/LateNight/mic_aux_rack.xml index e03cddd78fe..3fcf63e40c5 100644 --- a/res/skins/LateNight/mic_aux_rack.xml +++ b/res/skins/LateNight/mic_aux_rack.xml @@ -55,34 +55,18 @@ vertical min,min - - - MicDuckingButton - talkover_duck_mode - 3 - - 0 - buttons/btn_micDuck.svg - buttons/btn_micDuck.svg - OFF - - - 1 - buttons/btn_micDuck_over.svg - buttons/btn_micDuck_over.svg - AUTO - - - 2 - buttons/btn_micDuck_over.svg - buttons/btn_micDuck_over.svg - MANUAL - - - [Master],talkoverDucking - LeftButton - - + MicDuckingStrengthKnob diff --git a/res/skins/LateNight/mic_unit.xml b/res/skins/LateNight/mic_unit.xml index 64574042d55..d8630d01811 100644 --- a/res/skins/LateNight/mic_unit.xml +++ b/res/skins/LateNight/mic_unit.xml @@ -36,24 +36,12 @@ vertical min,max - - microphone_talkover - 2 - - 0 - buttons/btn_microphone_talkover_down.svg - buttons/btn_microphone_talkover.svg - - - 1 - buttons/btn_microphone_talkover_overdown.svg - buttons/btn_microphone_talkover_over.svg - - - ,talkover - LeftButton - - + @@ -120,24 +108,12 @@ - - pfl - MicPflButton - 2 - - 0 - buttons/btn_pfl_down.svg - buttons/btn_pfl.svg - - - 1 - buttons/btn_pfl_overdown.svg - buttons/btn_pfl_over.svg - - - ,pfl - - + @@ -147,43 +123,23 @@ horizontal min,min - - 35f,22f - EffectUnit_auxiliary_enabled - FxAssignButton - 2 - - 0 - FX 1 - - - 1 - FX 1 - - - [EffectRack1_EffectUnit1],group__enable - LeftButton - - - - - 35f,22f - EffectUnit_auxiliary_enabled - FxAssignButton - 2 - - 0 - FX 2 - - - 1 - FX 2 - - - [EffectRack1_EffectUnit2],group__enable - LeftButton - - + + + [Master],show_4effectunits @@ -197,81 +153,41 @@ horizontal min,min - - 30f,22f - EffectUnit_auxiliary_enabled - FxAssignButton - 2 - - 0 - FX 1 - - - 1 - FX 1 - - - [EffectRack1_EffectUnit1],group__enable - LeftButton - - - - - 20f,22f - EffectUnit_auxiliary_enabled - FxAssignButton - 2 - - 0 - 2 - - - 1 - 2 - - - [EffectRack1_EffectUnit2],group__enable - LeftButton - - - - - 20f,22f - EffectUnit_auxiliary_enabled - FxAssignButton - 2 - - 0 - 3 - - - 1 - 3 - - - [EffectRack1_EffectUnit3],group__enable - LeftButton - - - - - 20f,22f - EffectUnit_auxiliary_enabled - FxAssignButton - 2 - - 0 - 4 - - - 1 - 4 - - - [EffectRack1_EffectUnit4],group__enable - LeftButton - - + + + + + + + [Master],show_4effectunits diff --git a/res/skins/LateNight/mixer_master_headphone.xml b/res/skins/LateNight/mixer_master_headphone.xml index db62a35b26a..d47315b7c0b 100644 --- a/res/skins/LateNight/mixer_master_headphone.xml +++ b/res/skins/LateNight/mixer_master_headphone.xml @@ -82,43 +82,23 @@ horizontal me,min - - 35me,22f - EffectUnit_master_enabled - FxAssignButton - 2 - - 0 - FX 1 - - - 1 - FX 1 - - - [EffectRack1_EffectUnit1],group_[Master]_enable - LeftButton - - + - - 35me,22f - EffectUnit_master_enabled - FxAssignButton - 2 - - 0 - FX 2 - - - 1 - FX 2 - - - [EffectRack1_EffectUnit2],group_[Master]_enable - LeftButton - - + @@ -127,43 +107,23 @@ horizontal me,min - - 35me,22f - EffectUnit_master_enabled - FxAssignButton - 2 - - 0 - FX 3 - - - 1 - FX 3 - - - [EffectRack1_EffectUnit3],group_[Master]_enable - LeftButton - - + - - 35me,22f - EffectUnit_master_enabled - FxAssignButton - 2 - - 0 - FX 4 - - - 1 - FX 4 - - - [EffectRack1_EffectUnit4],group_[Master]_enable - LeftButton - - + [Master],show_4effectunits @@ -345,30 +305,20 @@ horizontal me,min - - 68f,22f - headSplit - FxAssignButton - 2 - - 0 - Split Cue - - - 1 - Split Cue - - - [Master],headSplit - - + - - 0min,0me --> diff --git a/res/skins/LateNight/quick_effect_knob_4decks.xml b/res/skins/LateNight/quick_effect_knob_4decks.xml index 45c61a1f412..89682c4f9f0 100644 --- a/res/skins/LateNight/quick_effect_knob_4decks.xml +++ b/res/skins/LateNight/quick_effect_knob_4decks.xml @@ -22,25 +22,12 @@ horizontal 22f,30min - - QuickEffectRack_enabled - 18f,18f - 2 - - 0 - buttons/btn_eq_kill_down.svg - buttons/btn_eq_kill.svg - - - 1 - buttons/btn_quickEffect_overdown.svg - buttons/btn_quickEffect_over.svg - - - ,enabled - LeftButton - - + [Master],show_eq_kill_buttons diff --git a/res/skins/LateNight/quick_effect_knob_left.xml b/res/skins/LateNight/quick_effect_knob_left.xml index 4e82ed61691..a4f90b43bcb 100644 --- a/res/skins/LateNight/quick_effect_knob_left.xml +++ b/res/skins/LateNight/quick_effect_knob_left.xml @@ -18,25 +18,12 @@ min,min 22,30 - - QuickEffectRack_enabled - 18f,18f - 2 - - 0 - buttons/btn_eq_kill_down.svg - buttons/btn_eq_kill.svg - - - 1 - buttons/btn_quickEffect_overdown.svg - buttons/btn_quickEffect_over.svg - - - ,enabled - LeftButton - - + [Master],show_eq_kill_buttons diff --git a/res/skins/LateNight/quick_effect_knob_right.xml b/res/skins/LateNight/quick_effect_knob_right.xml index 583752ac3ae..d1531e62d7a 100644 --- a/res/skins/LateNight/quick_effect_knob_right.xml +++ b/res/skins/LateNight/quick_effect_knob_right.xml @@ -31,25 +31,12 @@ min,min 22,30 - - QuickEffectRack_enabled - 18f,18f - 2 - - 0 - buttons/btn_eq_kill_down.svg - buttons/btn_eq_kill.svg - - - 1 - buttons/btn_quickEffect_overdown.svg - buttons/btn_quickEffect_over.svg - - - ,enabled - LeftButton - - + [Master],show_eq_kill_buttons diff --git a/res/skins/LateNight/rate_controls.xml b/res/skins/LateNight/rate_controls.xml index bf233effa02..799458bac18 100644 --- a/res/skins/LateNight/rate_controls.xml +++ b/res/skins/LateNight/rate_controls.xml @@ -82,7 +82,6 @@ vertical min,min - @@ -111,7 +112,7 @@ beats_translate_later FxAssignButton beats_later - 28f,28f + 26f,26f ,beats_translate_later @@ -119,7 +120,7 @@ beats_adjust_slower FxAssignButton beats_slower - 28f,28f + 26f,26f ,beats_adjust_slower @@ -134,6 +135,6 @@ visible - - + + diff --git a/res/skins/LateNight/waveforms.xml b/res/skins/LateNight/waveforms.xml index 380fbbcdf5f..d1097fe0531 100644 --- a/res/skins/LateNight/waveforms.xml +++ b/res/skins/LateNight/waveforms.xml @@ -15,20 +15,11 @@ - - BeatgridButtonsToggle - 28f,40me - 2 - - 0 - - - 1 - - - [Skin],beatgrid_buttons - - +