From 9d7c566a348a6f406b35d71a1ad49a228a253208 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Sch=C3=BCrmann?= Date: Thu, 1 Feb 2024 13:38:59 +0100 Subject: [PATCH 1/2] Fail early in case Taglib 2.0 is found --- CMakeLists.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index f38707f4acb..4e8c336091f 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -2940,6 +2940,9 @@ target_link_libraries(mixxx-lib PRIVATE SoundTouch::SoundTouch) # TagLib find_package(TagLib 1.11 REQUIRED) target_link_libraries(mixxx-lib PRIVATE TagLib::TagLib) +if (NOT TagLib_VERSION VERSION_LESS 2.0.0) + message(FATAL_ERROR "Installed Taglib ${TagLib_VERSION} is not supported. Use Version >= 1.11 and < 2.0 and its development headers.") +endif() # Threads set(THREADS_PREFER_PTHREAD_FLAG ON) From 4d02b1b5b0a4b4b0a7433475dc4b043e2fc9bb34 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Sch=C3=BCrmann?= Date: Sun, 4 Feb 2024 01:04:30 +0100 Subject: [PATCH 2/2] Add a warning for package maintainers Co-authored-by: Swiftb0y <12380386+Swiftb0y@users.noreply.github.com> --- CMakeLists.txt | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index 4e8c336091f..49e587cd46f 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -2942,6 +2942,10 @@ find_package(TagLib 1.11 REQUIRED) target_link_libraries(mixxx-lib PRIVATE TagLib::TagLib) if (NOT TagLib_VERSION VERSION_LESS 2.0.0) message(FATAL_ERROR "Installed Taglib ${TagLib_VERSION} is not supported. Use Version >= 1.11 and < 2.0 and its development headers.") + # Dear package maintainer: Do not patch away this fatal error + # using taglib 2.0.0 will put user data at risk!! + # Mixxx is a complex application that needs to be adapted and tested thoroughly + # https://github.com/mixxxdj/mixxx/issues/12708 endif() # Threads