Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixxx with ANGLE asserts always at startup #11994

Closed
JoergAtGithub opened this issue Sep 17, 2023 · 5 comments
Closed

Mixxx with ANGLE asserts always at startup #11994

JoergAtGithub opened this issue Sep 17, 2023 · 5 comments

Comments

@JoergAtGithub
Copy link
Member

JoergAtGithub commented Sep 17, 2023

Bug Description

If I enforce Mixxx 2.4 to run with ANGLE (OpenGL ES), it asserst as following:

warning [Main] QOpenGLShader::compile(Fragment): ERROR: 0:6: '' : No precision specified for (float)
ERROR: 0:7: '' : No precision specified for (float)

warning [Main] *** Problematic Fragment shader source code ***
#ifdef GL_KHR_blend_equation_advanced
#extension GL_ARB_fragment_coord_conventions : enable
#extension GL_KHR_blend_equation_advanced : enable
#endif
#line 1

uniform highp vec4 color;
varying highp float vgradient;
void main()
{
    float minAlpha = 0.5 * color.w;
    float maxAlpha = 0.83 * color.w;
    gl_FragColor = vec4(color.xyz, mix(minAlpha, maxAlpha, max(0.,vgradient)));
}

***
DEBUG ASSERT: "addShaderFromSourceCode( GLShader::Fragment, fragmentShaderCode)" in function void __cdecl mixxx::Shader::load(const class QString &,const class QString &) at C:\Users\Joerg.WORLDWARTWEB\source\repos\JoergAtGithub\mixxx\src\shaders\shader.cpp:24

Version

2.4.0

OS

Windows 11

@daschuer
Copy link
Member

Please try to chang the code to that:

  highp float minAlpha = 0.5 * color.w;
  highp float maxAlpha = 0.83 * color.w;

@Swiftb0y
Copy link
Member

some for all other shaders too...

@JoergAtGithub
Copy link
Member Author

Yes, this works!

@daschuer
Copy link
Member

Cool, would you mind to issue a PR?

@JoergAtGithub
Copy link
Member Author

Will do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants