Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Play button connections to be reliable with all Cue modes #9822

Closed
mixxxbot opened this issue Aug 23, 2022 · 4 comments
Closed

fix Play button connections to be reliable with all Cue modes #9822

mixxxbot opened this issue Aug 23, 2022 · 4 comments
Milestone

Comments

@mixxxbot
Copy link
Collaborator

Reported by: ronso0
Date: 2019-12-08T21:24:51Z
Status: Fix Released
Importance: High
Launchpad Issue: lp1855620
Tags: skin


As noticed in LateNight redesign ptII, the play toggle decoration is sometimes not applied correctly when it's toggled repeatedly quickly.
#2342 (comment)

Let's clean up how '[group],play' and '[group],play_indicator' are used in skins and also make sure the skin controls always receive the correct status with every Cue mode.

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2020-01-26T15:51:11Z


#2389

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2020-05-09T08:45:47Z


Is this finally fixed here?
#2619

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2020-05-09T13:40:42Z


Seems so, I can't reproduce it anymore.

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.3.0 milestone Aug 24, 2022
@ronso0 ronso0 added skins and removed skin labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants