Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libshout-1:2.4.2-1 breaks live broadcasting mixxx 2.2.1 #9681

Closed
mixxxbot opened this issue Aug 23, 2022 · 17 comments
Closed

libshout-1:2.4.2-1 breaks live broadcasting mixxx 2.2.1 #9681

mixxxbot opened this issue Aug 23, 2022 · 17 comments
Labels
broadcast Bugs pertaining to streaming radio broadcaster use-case bug
Milestone

Comments

@mixxxbot
Copy link
Collaborator

Reported by: remyjo
Date: 2019-06-18T12:00:42Z
Status: Fix Released
Importance: High
Launchpad Issue: lp1833225
Tags: broadcast
Attachments: mixxx.log


Hey, libshout version 1:2.4.2-1 seems to break the broadcasting. I can't connect to the server at all.

When I downgrade to libshout-1:2.4.1-4 the broadcast works again.

I'm using Manjaro stable, this uses the latest 1:2.4.2-1 version.

I'm not sure if this a problem on Mixxx's side or on the libshout side.

More info on this forum post https://www.mixxx.org/forums/viewtopic.php?f=3&t=12781

Thanks!

UPDATE: I also tested the newest libshout version 2.4.3 from git. This version is also broken. https://aur.archlinux.org/packages/libshout-git/

@mixxxbot mixxxbot added broadcast Bugs pertaining to streaming radio broadcaster use-case bug labels Aug 23, 2022
@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2019-06-18T19:14:33Z


What exactly happens when you cannot connect.
Does the mixxx.log file looks different?

@mixxxbot
Copy link
Collaborator Author

Commented by: remyjo
Date: 2019-06-18T19:37:09Z
Attachments: mixxx.log


I pasted the error from the log below. But I don't think it logs the libshout problem. Also the full log is attached.

I noticed there were 2 other people on the libshout github who also had this problem. xiph/Icecast-libshout#14

That's why I opened this issue also on there. xiph/Icecast-libshout#15

Debug [Main]: DlgPrefBroadcast - broadcastEnabledChanged() 1
Debug [ShoutOutput 'Connection 1']: ShoutConnection - run: Starting thread
Debug [ShoutOutput 'Connection 1']: ShoutConnection - processConnect
Debug [ShoutOutput 'Connection 1']: ShoutConnection - "Connection 1" : updating from preferences
Debug [ShoutOutput 'Connection 1']: ShoutConnection - Using server URL: QUrl("//[email protected]:8000/mount")
Debug [ShoutOutput 'Connection 1']: Successfully loaded encoder library  "mp3lame"
Debug [ShoutOutput 'Connection 1']: Loaded libmp3lame version  3.100
Debug [ShoutOutput 'Connection 1']: lame_set_VBR_quality:  "present"  lame_encode_buffer_interleaved_ieee_float:  "present"  id3tag_add_v2:  "present"
Debug [ShoutOutput 'Connection 1']:  CBR mode with bitrate:  160
Warning [ShoutOutput 'Connection 1']: ShoutConnection - 1 / 3 Streaming server failed connect. Failures: "Please retry current operation."
Warning [ShoutOutput 'Connection 1']: ShoutConnection - 2 / 3 Streaming server failed connect. Failures: "Please retry current operation."
Warning [ShoutOutput 'Connection 1']: ShoutConnection - 3 / 3 Streaming server failed connect. Failures: "Please retry current operation."
Debug [ShoutOutput 'Connection 1']: Unloaded libmp3lame 
Debug [ShoutOutput 'Connection 1']: ShoutConnection - processConnect() returning false
Warning [ShoutOutput 'Connection 1']: Streaming error:  "Please retry current operation.\nPlease check your connection to the Internet and verify that your username and password are correct."

@mixxxbot
Copy link
Collaborator Author

Commented by: remyjo
Date: 2019-06-20T09:08:57Z


UPDATE: This issue on libshout GitHub got moved to their GitLab page: https://gitlab.xiph.org/xiph/icecast-libshout/issues/2308

@mixxxbot
Copy link
Collaborator Author

Commented by: remyjo
Date: 2019-07-29T09:58:38Z


UPDATE: The problem is fixed! I just build the GitLab version and it works, no problems anymore.

https://gitlab.xiph.org/xiph/icecast-libshout/

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2019-07-29T15:08:28Z


But what does this mean for Mixxx and Linux users still using the faulty version?
Can we detect this and warn the users?
Or should we ship our own libshout build.
We can then also use the aac enabled version.

So I think this bug is still in progress.

@mixxxbot
Copy link
Collaborator Author

Commented by: remyjo
Date: 2019-07-29T15:50:47Z


It really depends on the distribution. Ubuntu and Debian based distributions still ship with libshout 2.4.1 and that version doesn't have the bug.

Arch based distributions ship with 2.4.3 which has this bug. So Arch based distribution users, can install the AUR version "libshout-git". This builds it straight from the GitLab source. https://aur.archlinux.org/packages/libshout-git/

I agree that the bug is still in progress until the commit get pushed in the next release.

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2019-08-17T14:03:48Z


Fedora is shipping libshoutcast 2.2.2 (all releases). This is what I use as a dependency for the RPM Fusions builds

Should I switch/upgrade to iceast 2.4.4?

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2019-08-17T14:16:26Z


Ok, so icecast is just the server? I only see libshout-devel 2.2.2.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2019-08-17T15:18:53Z


The patch is not released yet:
https://gitlab.xiph.org/xiph/icecast-libshout/-/tags
I guess we need at least > 2.4.3

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2019-08-29T11:24:18Z


A PR for Mixxx is here:
#2040
It reverts libshout to 2.4.1

@mixxxbot
Copy link
Collaborator Author

Commented by: remyjo
Date: 2019-12-18T15:36:54Z


Thanks for fixing the bug! I just build from source and can confirm it works. I really appreciate the work you guys do, thank you :)

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2020-01-15T21:23:17Z


Unfortunately the fix has not managed to go to 2.4.3 see:
https://gitlab.xiph.org/xiph/icecast-libshout/issues/2308
It was finally fixed here https://gitlab.xiph.org/xiph/icecast-libshout/commit/0ac7ed9e84c3871d4427acc1ce59dca5e4af21ef after the 2.4.3 release.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2020-01-15T21:30:03Z


#2438 rejects now 2.4.2 and 2.4.3

@mixxxbot
Copy link
Collaborator Author

Commented by: fabzgy
Date: 2020-04-28T16:36:14Z


I just did the Ubuntu release upgrade from 19.10 to 20.04 this morning and now I am stuck with this bug. Probably there are going to be more people facing this problem.
What is the best way to get out of this situation? Is there an apt repository for the 2.2.4 version?

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2020-04-28T18:06:20Z


Unfortunately there is no binary available for 2.2.4 yet.

I think the easiest way is to downgrade libshout:
By luck the eoan dep package can be installed
https://packages.ubuntu.com/eoan/libshout3

If you are not afraid for installing a lot of dev packages,you can build your own 2.2.4 alpha.
https://www.mixxx.org/wiki/doku.php/compiling_on_linux

If you are interested in bleeding edge features and like to help us towards the 2.3 release,
you can install:
https://launchpad.net/~mixxx/+archive/ubuntu/nightlies
But please backup your .mixxx folder first and test all your use cases before going live

@mixxxbot
Copy link
Collaborator Author

Commented by: hackerb9
Date: 2020-05-18T00:48:03Z


Thank you, @daschuer! It seems to be working. I helped a DJ install the following on his Debian laptop:

http://ppa.launchpad.net/mixxx/nightlies/ubuntu/pool/main/m/mixxx/mixxx_2.4.0~alpha~pre-0ubuntu1~master~git7378~bionic_amd64.deb

and finally Mixxx works again for going Live! Hurray! Just in time for his show tonight.

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.2.4 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
broadcast Bugs pertaining to streaming radio broadcaster use-case bug
Projects
None yet
Development

No branches or pull requests

1 participant