Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wishlist: Pre fill Preferences > Live Broadcasting > Stream Settings > Stream name value #9605

Closed
mixxxbot opened this issue Aug 23, 2022 · 12 comments
Labels
broadcast Bugs pertaining to streaming radio broadcaster use-case bug easy usability
Milestone

Comments

@mixxxbot
Copy link
Collaborator

Reported by: tezzy
Date: 2019-02-28T11:37:13Z
Status: Fix Released
Importance: Medium
Launchpad Issue: lp1818054
Tags: broadcast, easy, usability


Many Mixx users connect to Shoutcast 2 servers.

In "Preferences > Live Broadcasting > Stream Settings" there are 4 variables.

They are "Stream name", "Website", "Description" and "Genre".

The Mixxx manual says:

"Mixxx works with Shoutcast 2 using the Shoutcast 1 protocol if you provide a stream name in Preferences ‣ Live Broadcasting ‣ Stream Settings. If you don’t provide a stream name, Shoutcast 2 rejects the connection (where Shoutcast 1 would accept this case)."

Out of the box, the 1st, "Stream name" is blank. This trips up people that do not read the manual or forget.

I suggest the default mixxx.cfg file is modified....

From:

[Shoutcast]
...
stream_name
stream_website http://www.mixxx.org
stream_desc This stream is online for testing purposes!
stream_genre Live Mix
...

to:

[Shoutcast]
...
stream_name Mixxx
stream_website http://www.mixxx.org
stream_desc This stream is online for testing purposes!
stream_genre Live Mix
...

Something like this in diff should do it:

  • stream_name
  • stream_name Mixxx
@mixxxbot mixxxbot added broadcast Bugs pertaining to streaming radio broadcaster use-case bug easy usability labels Aug 23, 2022
@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2019-04-22T16:15:15Z


I would be happy to receive a GitHub Pull Request.

@mixxxbot
Copy link
Collaborator Author

Commented by: tezzy
Date: 2019-04-27T19:52:41Z


I looked in to this, it is more involved. The configuration file is created when Mixxx is run for the first time AND OR and or updated when Mixxx is upgraded.

Sorry, I am "out of my depth" to make a change.

@mixxxbot
Copy link
Collaborator Author

Commented by: pawbud
Date: 2020-08-20T14:28:26Z


I have been trying to find the mixxx.cfg file, May I please be guided with a relevant path(I tried searching for the file on github too)?

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2020-08-21T16:14:28Z


this is the file where the dialog is set up and processed:
https://github.com/mixxxdj/mixxx/blob/master/src/preferences/dialog/dlgprefbroadcast.cpp
and the GUI file:
https://github.com/mixxxdj/mixxx/blob/master/src/preferences/dialog/dlgprefbeatsdlg.ui

IIRC, after first start, there's IceCast selected in Pref > Live Broadcasting.
For the case mentioned (switch to shoutcast) you'd need to fill stream_name field with a placeholder.

@mixxxbot
Copy link
Collaborator Author

Commented by: pawbud
Date: 2020-08-23T10:30:03Z


i am not very familiar with XML but I tried to put a property tag with the name attribute and it didn't work.

@mixxxbot
Copy link
Collaborator Author

Commented by: pawbud
Date: 2020-08-23T14:26:38Z


I did switch to shoutcast and yet it didn't work, on top of that what if I tried putting a QString kDefaultStreamName=QObject::tr("Mixxx"), in here https://github.com/PawBud/mixxx/blob/master/src/preferences/broadcastprofile.cpp#L79, It was wrong but would you mind telling me what this file does then?

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2020-08-23T21:00:36Z


I'd say you also need to pick that default name here, instead of empty QString:
https://github.com/PawBud/mixxx/blob/master/src/preferences/broadcastprofile.cpp#L240

Discussion details is much easier in Zulip, so please head over to https://mixxx.zulipchat.com/

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2020-08-23T21:01:17Z


... and open a new thread in the development stream
https://mixxx.zulipchat.com/#narrow/stream/109171-development

@mixxxbot
Copy link
Collaborator Author

Commented by: pawbud
Date: 2020-08-24T04:54:15Z


Alright, Thanks a lot :)

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2020-08-31T11:06:52Z


#3043

@mixxxbot
Copy link
Collaborator Author

Commented by: tezzy
Date: 2020-11-19T00:29:01Z


Please excuse the delay the notification email went in the spam folder.

Thanks everybody for fixing this bug.

Best wishes.

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.3.0 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
broadcast Bugs pertaining to streaming radio broadcaster use-case bug easy usability
Projects
None yet
Development

No branches or pull requests

1 participant