Qt5: BIg Samplers are broken in Shade

[mixxxbot]

Reported by: daschuer
Date: 2018-05-26T21:52:37Z
Status: Fix Released
Importance: Medium
Launchpad Issue: lp1773588
Attachments: Screenshot

---

See screenshot.

[mixxxbot]

Commented by: daschuer
Date: 2018-05-26T21:52:37Z
Attachments: Screenshot

[mixxxbot]

Commented by: daschuer
Date: 2018-05-26T21:57:30Z

---

This was tested with Ubuntu Xenial and QT 5.5

Confirmed in https://mixxx.zulipchat.com/#narrow/stream/109122-general/subject/QT5.20build.20Master/near/127138224

[mixxxbot]

Commented by: ronso0
Date: 2018-06-23T11:24:50Z

---

I'd say it's due to unnecessary QWidget { margin: 0px; padding: 10px; } in sampler.xml:line6
Appearantly this has no effect in qt4 but is respected and rendered in qt5.
If this line is removed there's no difference with qt4. Please test with qt5.
I'd open a PR but I can't compile master with qt5 reliably right now.

[mixxxbot]

Commented by: ronso0
Date: 2018-06-23T11:25:43Z

---

https://github.com/mixxxdj/mixxx/blob/master/res/skins/Shade/sampler.xml#L6

[mixxxbot]

Commented by: daschuer
Date: 2018-07-22T11:11:43Z

---

Ah yes, Thank you.
Fixed in
#1759

[mixxxbot]

Issue closed with status Fix Released.