Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decoding of M4A on Windows might fail/abort #9266

Closed
mixxxbot opened this issue Aug 23, 2022 · 3 comments
Closed

Decoding of M4A on Windows might fail/abort #9266

mixxxbot opened this issue Aug 23, 2022 · 3 comments

Comments

@mixxxbot
Copy link
Collaborator

Reported by: uklotzde
Date: 2018-04-25T09:30:38Z
Status: Fix Released
Importance: Medium
Launchpad Issue: lp1766834
Tags: soundsource, windows


Successor of https://bugs.launchpad.net/mixxx/+bug/1490580

It turns out that the conversion from stream units (100 ns) to sample frames might be inaccurate due to rounding errors. The calculated position in frames within the stream is sometimes 1 less than the actual position when using StreamUnitConverter::toFrameIndex(), although adding the frame index bias should already account for and prevent this situation.

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2018-04-25T09:32:24Z


Example:
http://psycle.free.fr/josepma/mixxxm4abug/DHT%20-%20True%20love%20(Makina%20Mix)%20-%20bad.m4a

Waveform analysis always stops at the same position:
Warning [AnalyzerQueue 1]: AnalyzerQueue - Aborting analysis after failed to read sample data from "C:/Users/uk/Music/Mixxx Library/DHT - True love (Makina Mix) - bad.m4a" : expected frames = [1323008 -> 1327104) , actual frames = [11156506 -> 11156506)

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2018-04-25T14:29:39Z


#1646

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.1.1 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant