library context menu also shows not supported samplers

[mixxxbot]

Reported by: nopeppermint
Date: 2018-01-29T21:48:51Z
Status: Confirmed
Importance: Low
Launchpad Issue: lp1746105
Tags: easy

---

right click content menu, shows also not supported samplers:
Is it necessary to show all 64 Samplers, even if the current skin only supports 4 ?

https://user-images.githubusercontent.com/3403218/35532697-638473ca-053b-11e8-80ea-efa4b3cf82c0.png

[mixxxbot]

Commented by: nopeppermint
Date: 2018-04-22T19:36:38Z

---

I tried to fix this, adding 
"<attribute config_key="[Master],num_samplers">4</attribute>"
to skin.xml does not help..

[mixxxbot]

Commented by: Be-ing
Date: 2018-04-23T14:47:53Z

---

[Master], num_samplers cannot be decreased, only increased. If you load a skin with 64 samplers or there are 64 samplers in your samplers.xml file, num_samplers will be set to 64.

[mixxxbot]

Commented by: nopeppermint
Date: 2018-04-23T19:06:58Z

---

then we might introduce another variable which shows the actually supported/visible samplers in a skin?

[mixxxbot]

Commented by: Be-ing
Date: 2018-04-23T21:16:29Z

---

I don't think that's a good idea for the long term. Skins supporting different number of samplers is an ugly short term hack around the dramatic increase in startup and shutdown times when the number of samplers in the skin is increased.

[mixxxbot]

Commented by: ronso0
Date: 2018-06-02T15:33:14Z

---

If I load Deere (16 samplers) and read '[Master],num_samplers' in Developer Tools it still says "64".
What's the point of [Master],num_samplers in skin manifest then?

[mixxxbot]

Commented by: Be-ing
Date: 2018-06-02T15:48:03Z

---

That is probably because you have 64 samplers saved in ~/.mixxx/samplers.xml

[mixxxbot]

Commented by: ronso0
Date: 2020-11-02T20:01:08Z

---

No, skin.xml says "[Master],num_samplers">16
the sampler.xml has 16 samplers loaded, I even removed the empty node 17-64.
Sample applies when I load a similiar custom sampler banks.