Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loop_move_XX_forward & scratching disables Loop #8824

Closed
mixxxbot opened this issue Aug 23, 2022 · 5 comments
Closed

Loop_move_XX_forward & scratching disables Loop #8824

mixxxbot opened this issue Aug 23, 2022 · 5 comments
Labels
Milestone

Comments

@mixxxbot
Copy link
Collaborator

Reported by: ronso0
Date: 2017-03-02T16:19:36Z
Status: Fix Released
Importance: Medium
Launchpad Issue: lp1669500


I experience that loop_move_xx_forward exits the loop if moved over loop_out boundary.

Same happens when scratching backwards over loop_in, which I do after setting a loop and then scratching until I find the right point to drop it.

Reproduce:
1 load a track
2 play, set up a loop
3 scratch backwards over loop_in

play position jumps to loop_out
loop is disabled

6112 built from source
6359 faad=1 ffmpeg=0
6359 faad=0 ffmpeg=1
6359 faad=0 ffmpeg=0

might be related to Bug 1475442

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2017-10-13T07:36:45Z


I tested again, this behavior occurs very unpredictably.
Sometimes scratching works perfectly when loading a track the first time in a session, but with same track reloaded later on, it would fail.

@mixxxbot mixxxbot added the bug label Aug 23, 2022
@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2017-10-13T07:37:17Z


Also it seems to be codec dependent. I discoverd a .wma which always works.

6359 faad=0 ffmpeg=1

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2017-10-13T10:16:46Z


I tried [WiP] Universal SoundSource based on FFmpeg 3.1 (and beyond)
#1356
and appearantly it's fixed for some mp3 and wav files that fail with master.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2017-11-01T21:36:28Z


A possible fix is in:
#1367

I have found a rounding issue when playing at fast rates.
OTOH this does not explain why it is fixes with FFmpeg 3.1

Maybe you see a different issue?

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.1.0 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant