Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify effects skins around Deere #8424

Closed
mixxxbot opened this issue Aug 22, 2022 · 17 comments
Closed

unify effects skins around Deere #8424

mixxxbot opened this issue Aug 22, 2022 · 17 comments

Comments

@mixxxbot
Copy link
Collaborator

Reported by: ywwg
Date: 2016-01-06T15:06:27Z
Status: Fix Released
Importance: Medium
Launchpad Issue: lp1531519
Tags: effects, polish, skin, usability


It looks like Deere has the best interface for working with effects. Let's unify around that interface by factoring the effects bar into an xml template that can be used by all of the skins. The other skins should be able to apply CSS to make the panel blend in. Then we only have one place to change the effects interface rather than 3.

@mixxxbot
Copy link
Collaborator Author

Commented by: Pegasus-RPG
Date: 2016-01-06T15:22:19Z


Excellent idea, but isn't this too much work to be done for 2.1?

@mixxxbot
Copy link
Collaborator Author

Commented by: ywwg
Date: 2016-01-06T16:06:02Z


We can always push it back, but we might be able to at least make some headway. Not sure what our planned branch date is for 2.1

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2016-01-06T18:47:30Z


The idea is good, but the implementation will be hard. Deere exposes the
most features of the underlying framework but it is almost unusable on
small screens. It will have problems es well on big screen if we starting
to use the lv2 branch with 8 or more parameters.

We have also a usability issue since it targets the minority of advanced
effect users.

I have tried to target that issue in Shade by reducing the gui elements to
a minimum. It offers only the right and left bus effect. It can stack only
two effects, but has a comfortable space for 8 knobs.

.. but it does not meet advanced requirements.

Conclusion: We need to go back to the drafting stage. Maybe we can come up
with a modular Gui. Or two or more alternative bars for the different tusr
cases or controller layouts
Am 06.01.2016 5:15 nachm. schrieb "Owen Williams" <email address hidden>:

We can always push it back, but we might be able to at least make some
headway. Not sure what our planned branch date is for 2.1

--
You received this bug notification because you are a member of Mixxx
Development Team, which is subscribed to Mixxx.
https://bugs.launchpad.net/bugs/1531519

Title:
unify effects skins around Deere

Status in Mixxx:
New

Bug description:
It looks like Deere has the best interface for working with effects.
Let's unify around that interface by factoring the effects bar into an
xml template that can be used by all of the skins. The other skins
should be able to apply CSS to make the panel blend in. Then we only
have one place to change the effects interface rather than 3.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mixxx/+bug/1531519/+subscriptions

@mixxxbot
Copy link
Collaborator Author

Commented by: ywwg
Date: 2016-01-06T19:00:27Z


deere and latenight have similar size requirements so we could at least unify those two

@mixxxbot
Copy link
Collaborator Author

Commented by: Be-ing
Date: 2016-01-07T03:42:03Z


IMO this should be a release blocker for 2.1.

@mixxxbot
Copy link
Collaborator Author

Commented by: Be-ing
Date: 2016-01-07T03:49:38Z


I think the best strategy to handle all use cases, from making use of all engine features to using effects on a netbook screen, is to design multiple modes that display different levels of detail.

@mixxxbot
Copy link
Collaborator Author

Commented by: Pegasus-RPG
Date: 2016-01-07T05:10:51Z


Like responsive CSS Web site design? Can we do that in Qt?

@mixxxbot
Copy link
Collaborator Author

Commented by: Be-ing
Date: 2016-01-07T06:03:55Z


I have no comment about the technical implementation of it because I don't know the skin system very well. I think the various modes should be easily toggled similar to other skin options, like 2/4 decks and hide/show samplers.

@mixxxbot
Copy link
Collaborator Author

Commented by: sblaisot
Date: 2016-01-07T07:04:58Z


maybe we can also think of an "advanced" pane for effect editing (something like the sandwich menu in deere) with the most advanced effects options we don't need/want on the interface directly and only keep most used controls on the main interface.

most of the time, DJ setup their effects before the show and only adjust the strength of the effect and the channel they are applied to during the gig.

@mixxxbot
Copy link
Collaborator Author

Commented by: ywwg
Date: 2016-01-07T14:47:21Z


This bug is strictly limited to the near-term goal of taking the existing Deere effects UI and generalizing it so LateNight can use it. Please keep more general discussion about the UI in the mailing list.

@mixxxbot
Copy link
Collaborator Author

Commented by: esbrandt
Date: 2016-01-09T10:16:51Z


Adapting this to Latenight should not be too hard , since the Deere uses mostly templates.

Begs the question why we maintain multiple skins at all, rather then allowing loading of CSS at runtime. Also see lp:1402236

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2016-01-09T13:23:38Z


A css feature similar to colour schemas solves the visual beauty taste. So I like the idea to improve the situation here.

On other aspects of a skin we should keep in mind is that it support one or more special use case like beginner, advanced, radio DJ scratching DJ vinyl control DJ and so on.
We may try to catch them by config option. But the downside of such an "eierlegende Wollmilchsau" is that it may fail for very special demands. This may happen also because the maintainer, the head of the design as the taste master does not feel there requirements of some use cases.
That is the reason why I think we need dedicated skins for use-cases as well.

@mixxxbot
Copy link
Collaborator Author

Commented by: Be-ing
Date: 2017-08-01T16:38:26Z


Deere and Tango have both implemented the new 2.1 effects UI:
#1063
#1151

@mixxxbot
Copy link
Collaborator Author

Commented by: sblaisot
Date: 2017-11-13T20:44:18Z


shouldn't this one be kept open until Latenight is updated ?

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2017-11-13T22:35:32Z


and Shade ..

@mixxxbot
Copy link
Collaborator Author

Commented by: Be-ing
Date: 2018-03-24T14:42:29Z


LateNight:
#1489

Shade:
#1459
#1551

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@ronso0 ronso0 added skins and removed skin labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants