Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BPM Sync for effects #8312

Closed
mixxxbot opened this issue Aug 22, 2022 · 10 comments
Closed

BPM Sync for effects #8312

mixxxbot opened this issue Aug 22, 2022 · 10 comments

Comments

@mixxxbot
Copy link
Collaborator

Reported by: naught101
Date: 2015-11-20T06:06:28Z
Status: Fix Released
Importance: Wishlist
Launchpad Issue: lp1518185
Tags: effects, lv2


There are quite a few effects with time-period settings. For all of these, it would be great if there was a sync option, that would change the time-setting knob to a selector for BPM multiples/divisions (1/16, 1/4, 3/4, 1/1, 2/1, etc.).

The relevant knobs are:

Flanger: Period
Echo: Delay
AutoPan: Period

There are quite a few LV2 plugins with MIDI-syncable periods as well, so it would be good if this worked with those plugins when LV2 support is introduced.

@mixxxbot
Copy link
Collaborator Author

Commented by: z-rob-e
Date: 2016-04-08T19:59:22Z


This is at the top of my wishlist. Please, please prioritize this. For echo specifically.

@mixxxbot
Copy link
Collaborator Author

Commented by: Be-ing
Date: 2017-01-13T08:24:12Z


There is now a sync button for autopan, but not yet for echo or flanger.

To really make use of this will require a new type of effect parameter for discrete values. That issue is tracked separately in Bug #⁠1656225.

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2017-01-20T15:57:22Z


Coming from #⁠1656225

I'll join in to push this idea!
IMO especially the Echo effect is only usable for 'random delay' effect ATM. It's very hard to somehow adjust Echo delay on Pfl first (for a running track) then apply it to Channel and mix it in. Matching the BPM is pure chance...or hard work/time.

I imagine that it's kind of hard to implement: first press Echo's 'Sync' button then adjust a stepped Potmeter to set the delay to 1, 1/2, 1/4 of a beat.
When a new track is loaded, I'd expect both to reset to some default value, like 1/2 or 1 beat of track's BPM, or better: the stepped Potmeter's last value.

Btw: Isn't that the way way some of those fancy (Pioneer?) mixers handle it?

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2017-01-20T15:59:44Z


bug #⁠1656225

@mixxxbot
Copy link
Collaborator Author

Commented by: z-rob-e
Date: 2017-01-20T20:25:11Z


Just chiming in, glad to see some movement on this much needed feature.

@mixxxbot
Copy link
Collaborator Author

Commented by: Be-ing
Date: 2017-05-10T07:42:12Z


Pull request for echo effect: #1256

@mixxxbot
Copy link
Collaborator Author

Commented by: Be-ing
Date: 2017-05-15T00:00:27Z


pull request for flanger: #1257

@mixxxbot
Copy link
Collaborator Author

Commented by: Be-ing
Date: 2017-05-15T02:00:43Z


pull request for phaser: #1261

@mixxxbot
Copy link
Collaborator Author

Commented by: Be-ing
Date: 2017-11-12T20:42:30Z


Further work was done in these PRs:
#1335
#1350

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.1.0 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant