Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have a way to change the effect of the QuicEffectRack via js scripting. #8257

Closed
mixxxbot opened this issue Aug 22, 2022 · 8 comments
Closed
Labels
Milestone

Comments

@mixxxbot
Copy link
Collaborator

Reported by: DJChloe
Date: 2015-10-13T15:06:49Z
Status: Fix Committed
Importance: Wishlist
Launchpad Issue: lp1505721


Mixxx 1.12

Are there any mean to be able to change the effect of the
[QuickEffectRack1_[ChannelX]_Effect1] via javascript ?

Thank you

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2015-10-13T15:41:27Z


Does
[QuickEffectRack1_[ChannelX]Effect1],"next_effect"
[QuickEffectRack1
[ChannelX]_Effect1],"prev_effect"
work for you?

@mixxxbot
Copy link
Collaborator Author

Commented by: DJChloe
Date: 2015-10-13T16:45:51Z


not at all, I have tried every combinations found with the group Effectrack (effect_selector,next_effect,prev_effect, etc.... without any success.
There is no error message in the debug windows saying "that function does not exist".

This is the effect button in the equalizer part of the skin and it seems it can be changed only via
options -> Settings --> equalizer ->quick effect.

@mixxxbot
Copy link
Collaborator Author

Commented by: DJChloe
Date: 2015-10-13T16:58:01Z


In fact, in the source code, there is no control conect other than the "super1".
https://github.com/mixxxdj/mixxx/blob/master/src/controllers/controlpickermenu.cpp#L413

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2015-10-13T18:33:34Z


Ah yes, I can confirm that these controls are not working for Quick effects.

Hint:
You can see and access all controls in the developer menu, when you start Mixxx with the --developer flag.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2015-10-13T18:36:18Z


Please tell us mode about your use case.

Th quick effect was designed for controllers with a "fixed" filter knob.
I think that's why you can currently only change the loaded effect by preferences.

@mixxxbot
Copy link
Collaborator Author

Commented by: DJChloe
Date: 2015-10-13T19:55:52Z


On my Reloop Beatpad controller I have a knob for each channel labelled "FX Select" .

In non shift mode, I mapped this knob in my mapping in order to select an effect in an effect rack, I would like to do the same for the quick effect rack t, while pressing the shift button.

I have, per channel, two "Super knobs", I use one (labelled "FX Param") for the Effect Racks, and the other (labelled "Filter") for the Quick effect.

While mixing, you can put side by side one hand on the FX Select, and the other hand on one of the Super knob, or even of on the two Super buttons.

Powerfulll...

I have four Pads also, when they are in "Instant FX" mode, pressing one activates the effect loaded in the corresponding effect rack.
Shift+Pad, selects the effect rack to be modified by the "FX Select" knob.
What is a bit ugly there is that the user has no visual feedback about wich efect rack is currently selected for the "FX Select", here came the idea of a free text zone available in the skin for the scripting engine.

@mixxxbot
Copy link
Collaborator Author

Commented by: Be-ing
Date: 2020-05-10T14:21:37Z


Implemented in #2618

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Committed.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.4.0 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant