Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to color code tracks #6852

Closed
mixxxbot opened this issue Aug 22, 2022 · 20 comments
Closed

Allow user to color code tracks #6852

mixxxbot opened this issue Aug 22, 2022 · 20 comments

Comments

@mixxxbot
Copy link
Collaborator

Reported by: broma0-deactivatedaccount
Date: 2013-01-17T17:42:01Z
Status: Fix Released
Importance: Wishlist
Launchpad Issue: lp1100882
Tags: easy, library, usability, weekend
Attachments: [Mixxx library track color column](https://bugs.launchpad.net/bugs/1100882/+attachment/4791809/+files/Mixxx library track color column), [Mixxx library track color column](https://bugs.launchpad.net/bugs/1100882/+attachment/4794702/+files/Mixxx library track color column)


An extremely useful feature that Mixxx could benefit from is having the ability to color code individual tracks.

Use Case:

I want to organize my music collection in a very quick and easy way that allows me to simply glance at tracks and know how they sound, etc. I would right click on a song and select mouse over "Set Color". Another menu would open up at which point I would be able to select a set of predefined colors for the text in the library.

Predefined colors could include:

Light blue (I would use this for chill songs)
Royal Blue (songs that I'll play after the party, club, etc, gets going)
Orange (getting more intense)
Red (the real bangers' of my collection)

The colors above should look good on most dark backgrounds, but darker variations could also be included if one is using a theme with a light background.

@mixxxbot
Copy link
Collaborator Author

Commented by: rryan
Date: 2013-01-17T18:28:46Z


Neat side-project / wishlist idea. I agree color is a useful organizational tool that your brain is good at dealing with.

@mixxxbot
Copy link
Collaborator Author

Commented by: hasitnm
Date: 2014-03-25T04:24:14Z


Oh yes. Something on the lines of tags in Mac? It could be added as a column next to the track name list with a drop down menu to select a colour. This would be a good addition indeed.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2014-03-25T07:30:34Z


This is a good start.

Advanced:

  • extend this to bitmaps
  • overlays

@mixxxbot
Copy link
Collaborator Author

Commented by: karansanwal
Date: 2014-12-27T15:54:51Z


Hey. I would like to work on this bug, but I had a suggestion/modification :

Rather than adding a new column for the color tag, we could make changes in dlgtrackinfo.cpp such that, it sets the background color for Trackno or Trackname ( or the entire cell, but that could look ugly) based on the what ptrack->getgenre() returns ?

We could think out the default colors for genre, and also the default for when none is specified.

Let me know if this is acceptable, otherwise i will work on what was specified till now.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2014-12-28T13:43:59Z


You heading for a color code for genres only, right?
This is only useful for users who have cleaned up the genre tags for their entire library, so thats might be a bit to short to be a
gneric solution.

I would prefer to color tag the tracks independent from any other metadata, but add a feature that calculates a color from any cloumn on demand. This way we may use genre colors for some users, other my prefer Key or BPM.

For me the tack number column is useless for DJing, so it is hidden on my setup.
Using the Track name background or the font color would work for me.

An additional "cover" column for adding genre covers, colored rectangles or any other picture giving useful information would be also a good solution. We have also discussed to generate a picture using genre bpm and Key, but that is too advanced for this.

@mixxxbot
Copy link
Collaborator Author

Commented by: karansanwal
Date: 2014-12-28T17:34:07Z


Oh yes, that makes more sense.
To give user the power to select the color, would require a pallete for them to the select color from ?

Could you hint me on how to get started ?

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2014-12-28T17:51:04Z


What will you go for? An extra column or a changing the background?
You may start with adding functions that allow to change the color of a track title.
I have now idea how, but I am sure you find something in the WWW.

If you go for the coloum solution. You may have a look at the cover column code. I am sure you can reuse a lot of this code.

For the color editor, it would be nice to do a scribbled mock-up, (you may use just inkscape or any other drawing tool of your choice)

In on of your early version it is OK, to use a hard coded color mapping of genres as you have purposed above.
This way we can have a early prove of concept.

Hope that helps, please keep asking if required.

@mixxxbot
Copy link
Collaborator Author

Commented by: esbrandt
Date: 2014-12-30T11:40:49Z


No changing background colors in track names or other tricks please.
Keep it simple and add an separate color column, that can be hidden eventually.

Leave it to the user what they use the color column for.
A strict categorization based on existing genre tags is not flexible enough. If the user decide to use it like that , fine. He can filter by genre, select all, and apply a color. Others might want to apply color labels based on track energy, or track notation.

Id suggest to allow to select from a simple color scheme, according to https://www.beatunes.com/en/open-key-notation.html

@mixxxbot
Copy link
Collaborator Author

Commented by: karansanwal
Date: 2014-12-30T20:59:49Z


Firstly, Thanks for helping out here.

Oh alright, though it was not the option i was working on, I think your suggestion is valid, as adding an extra coloumn is always better.

This might take time, as i am travelling this week, but i'll try to make most of the time i get.

@mixxxbot
Copy link
Collaborator Author

Commented by: karansanwal
Date: 2015-01-10T15:41:20Z


I was able to add the color column in the track properties section, but i am somehow finding it too hard to add it in the right place.
Can i be further hinted ? 
Sorry to keep you guys waiting for this :|
Thanks a lot for the patience.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2015-01-10T16:18:11Z


You may add a pull request against master of your current state, and add a comment that there is work in progress.
Maybe we can give some hints than.

@mixxxbot
Copy link
Collaborator Author

Commented by: johndoemixxx
Date: 2016-12-15T03:01:12Z
Attachments: [Mixxx library track color column](https://bugs.launchpad.net/mixxx/+bug/1100882/+attachment/4791809/+files/Mixxx library track color column)


See the attached patch which is inspired by the star rating library
column and other parts of the Mixxx code. The rest of the new code
modifications is public domain. Please feel free to test, fix bugs
and submit to the main Mixxxx code repository.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2016-12-15T07:48:48Z


Thank you very much for the patch.

I have not yet looked into it.

Did you consider to publish it as GitHub pull request.
This simplifies the review process a lot.

Here are some more hints:
http://www.mixxx.org/wiki/doku.php/bugfix_workflow

In order to commit your patch, we need your permission.
Please sign:
https://docs.google.com/a/mixxx.org/spreadsheet/viewform?formkey=dEpYN2NkVEFnWWQzbkFfM0ZYYUZ5X2c6MQ

and comment here when done.

By the way, what happens with your patch here?
https://bugs.launchpad.net/mixxx/+bug/1645054

@mixxxbot
Copy link
Collaborator Author

Commented by: johndoemixxx
Date: 2016-12-21T11:46:44Z
Attachments: [Mixxx library track color column](https://bugs.launchpad.net/mixxx/+bug/1100882/+attachment/4794702/+files/Mixxx library track color column)


Simplified and removed the editor class. I won't sign the
contributors agreement, but everyone is free to do whatever
they want with the code including uploading it to github.

@mixxxbot
Copy link
Collaborator Author

Commented by: johndoemixxx
Date: 2018-08-02T23:07:42Z


PR#⁠1771 beenisss (Y)

I probably would sign the agreement if the code
would be GPL with no exceptions and changes would
require my approval, no time limit.

But this patch is is free for all. Hope someone
can get this feature into Mixxx with or without
this patch.

@mixxxbot
Copy link
Collaborator Author

Commented by: beenisss
Date: 2018-08-07T19:18:39Z


It doesn't sound like it will be possible to use that patch if you don't want to sign the agreement, even if you otherwise consent to it explicitly.

@mixxxbot
Copy link
Collaborator Author

Commented by: rryan
Date: 2018-09-20T17:30:34Z


@john Doe -- by "everyone is free to do whatever they want with the code", do you mean you are offering it into the public domain?

@mixxxbot
Copy link
Collaborator Author

Commented by: johndoemixxx
Date: 2018-12-21T00:01:02Z


The code I have posted in this bug report is in the public domain.

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2020-01-28T13:48:10Z


Great you start working on this! In conjunction with the star rating this will be very helpful.
To pick a color per mood, energy or custom 'code' a rainbow palette would work best IMO.

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.3.0 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant