Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Missing Icons in Deere with 150% Scaling #13959

Closed
uklotzde opened this issue Dec 1, 2024 · 11 comments
Closed

UI: Missing Icons in Deere with 150% Scaling #13959

uklotzde opened this issue Dec 1, 2024 · 11 comments

Comments

@uklotzde
Copy link
Contributor

uklotzde commented Dec 1, 2024

Bug Description

100%

Screenshot From 2024-12-01 23-32-24

150%

Screenshot From 2024-12-01 23-31-18

Version

main

OS

Fedora 41

@uklotzde uklotzde added the bug label Dec 1, 2024
@daschuer
Copy link
Member

daschuer commented Dec 1, 2024

I can not exactly confirm the issue with Ubuntu Jammy, but there is at least an issue:
grafik

The 2.5 branch is also affected.

2.4.2 works as expected but has blurry icons.

@daschuer daschuer added this to the 2.5.0 milestone Dec 1, 2024
@uklotzde
Copy link
Contributor Author

uklotzde commented Dec 1, 2024

Might be unrelated:

warning [Main]      $ connectMenuBar
warning [Main] Failed to load pixmap from path: "skin:/buttons/btn_"

@uklotzde
Copy link
Contributor Author

uklotzde commented Dec 2, 2024

The artifacts in the upper left corners disappear after hovering over the almost empty buttons:

Screenshot From 2024-12-02 02-33-51

@daschuer
Copy link
Member

daschuer commented Dec 2, 2024

The 2.5 qt5 build is not affected.

@uklotzde
Copy link
Contributor Author

uklotzde commented Dec 2, 2024

More glitches.

Screenshot From 2024-12-02 19-22-30

@ronso0
Copy link
Member

ronso0 commented Dec 2, 2024

The culprit seems to be that the loop icon has width and height set, while loop_in doesn't.
Both have the viewbox property set viewBox="0 0 48 48"
https://github.com/mixxxdj/mixxx/blob/main/res/skins/Deere/icon/ic_loop_in_48px.svg?short_path=2502654
https://github.com/mixxxdj/mixxx/blob/main/res/skins/Deere/icon/ic_loop_48px.svg?short_path=a969991

@uklotzde Can you try adding width="48" height="48" to the <svg> node of loop_in and check if that fixes it?

@uklotzde
Copy link
Contributor Author

uklotzde commented Dec 3, 2024

Seems to work with explicit height/width:

image

@ronso0
Copy link
Member

ronso0 commented Dec 3, 2024

Okay, great, thanks for verifying!

So the tasks is now to ensure all Deere icons have these set 😬
(and maybe double-check the other skins..)

@ronso0
Copy link
Member

ronso0 commented Dec 3, 2024

related: #12407
@m0dB are you motivated to adapt your perl script and sick it on the Deere icon set?

@m0dB
Copy link
Contributor

m0dB commented Dec 3, 2024

Sure! It will have to wait until the weekend though.

@ronso0
Copy link
Member

ronso0 commented Dec 12, 2024

fixed by #14013

@ronso0 ronso0 closed this as completed Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants