Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Kill Mid" and "High" affect each other in the Waveform Display #13922

Closed
g-rden opened this issue Nov 23, 2024 · 5 comments
Closed

"Kill Mid" and "High" affect each other in the Waveform Display #13922

g-rden opened this issue Nov 23, 2024 · 5 comments

Comments

@g-rden
Copy link

g-rden commented Nov 23, 2024

Bug Description

I won't go into depth describing the bevavior. Because either I am completely missing something and there's no bug or it is apperent that something is wrong and must be looked into further anyway.

BUG:
"Kill Mid" button and "High" knob affect each other in the Waveform Display when using "Filtered", "RGB" or "Stacked" Waveform Type. This does only affect the Waveform Display as the audio output is as expected.

Image shows two cases (there are more) where the display is incorrect.
mixxx 2.4.1

edit: Just noticed the "Kill High" button does not affect the Waveform Display.

Version

2.4.1, 2.6-alpha-136-g894e96f9b2 (main)

OS

Linux 6.11.9-arch1-1

@Swiftb0y
Copy link
Member

I can reproduce in 2.4.1

@Swiftb0y
Copy link
Member

Swiftb0y commented Nov 23, 2024

As far as I can tell, the issue is that the high kill does nothing and the middle kill kills high and mid bands. Lows work as expected. Affected waveform types are (Mixxx 2.4) "Filtered", "Filtered (GLSL)"m "Filtered (legacy, GL)", "RGB", "RGB (GLSL)", "RGB (legacy, GL)", "RGB L/R (GLSL)". Does that match your observation @g-rden?
EDIT: this list only applies to the mid+high issue... Others are also affected by missing eq high handling...

@Swiftb0y
Copy link
Member

Found (part of) the culprit: 94041d8

@Swiftb0y
Copy link
Member

@g-rden can you please confirm whether #13923 fixes the issues you reported?

@g-rden
Copy link
Author

g-rden commented Nov 23, 2024

Sorry that I was unresponsive. Yes it works! Thank you

@g-rden g-rden closed this as completed Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants