Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stars rating is lose when right click on multiple tracks. #13597

Closed
j-wiedemann opened this issue Aug 25, 2024 · 5 comments
Closed

Stars rating is lose when right click on multiple tracks. #13597

j-wiedemann opened this issue Aug 25, 2024 · 5 comments

Comments

@j-wiedemann
Copy link

Bug Description

Select multiple tracks at the same time, tracks should have different stars count.
Right click on one track to edit all selected tracks (like if you want to apply a color to all selected tracks).
Notice that stars rating is gone for all selected tracks.

No problem on Mixxx 2.4.1

Version

2.5-beta-43-g34aa89c780

OS

PopOS 22.04 (Ubuntu 22.04), X11, NVIDIA

@ronso0
Copy link
Member

ronso0 commented Aug 25, 2024

Thanks for the report!
I can not confirm, neither by only opening the context menu, nor by doing some mass-edit (tested color, reset playcount, reset BPM).

Right click on one track to edit all selected tracks

Or do yo mean you open Track Properties for the selected tracks, edit some tag, Appl/Okay, and then the rating is reset?

Can you please provide a short screencast of the issue?

@j-wiedemann
Copy link
Author

bug.mixxx.stars.webm

Hello,
I was having hard time to reproduce. So I try different things as you can see on the video.
It look like its have to be new added song...
Sorry for the quality, have to reduce the video size. You can see the stars disappear at 1:14.

@ronso0
Copy link
Member

ronso0 commented Aug 28, 2024

Alright, thanks for taking the time.

I could reproduce a few times (though not relaibly) with these steps:

  1. track C selected
  2. change the star rating of track A (selects track A) to > 0
  3. hold Shift
  4. move cursor over stars of track B to (empty) title field of track B
  5. click on track B title (A + B selected, "selectedClick is switched Off)
  6. right-click on track B
    = menu pops up, ratings of A and B are reset to zero

I'll try to repro again with the "selectedClick" switch disabled.

@daschuer daschuer added this to the 2.5.0 milestone Aug 28, 2024
@ronso0
Copy link
Member

ronso0 commented Aug 28, 2024

I'll try to repro again with the "selectedClick" switch disabled.

That workaround is unrelated, can now repro somewhat reliably with the steps from above.
(and couldn't repro with 2.4.2 until now)

@ronso0
Copy link
Member

ronso0 commented Aug 29, 2024

Got it, fix is #13609

@ronso0 ronso0 closed this as completed Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants