Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library: make BPM display and editing locale consistent #13051

Closed
ronso0 opened this issue Apr 5, 2024 · 2 comments
Closed

Library: make BPM display and editing locale consistent #13051

ronso0 opened this issue Apr 5, 2024 · 2 comments
Labels
Milestone

Comments

@ronso0
Copy link
Member

ronso0 commented Apr 5, 2024

Bug Description

BPM display:
126.789 (dot)

BPM editor:
126,78900000 (comma)

When I open the editor and type 126. (dot) any further num input is rejected.
The editor would only accept comma as separator.
edit: apparently this happens because . is recognized as thousands separator and the spinbox is limited to 999.

edit: I can't get . as BPM separator in the library if I select German locale in Mixxx.

Locale Settings:

LANG=en_GB
LANGUAGE=en_GB:en
LC_NUMERIC=de_DE.UTF-8
LC_TIME=de_DE.UTF-8
LC_MONETARY=de_DE.UTF-8
LC_MEASUREMENT=de_DE.UTF-8

  • system locale is en_GB, in Mixxx I selected System.
    so my numpad separator is ,

Fix:

Use the same separator for both.

Ideal:

Show same separator in table and editor, allow both in editor.

Version

No response

OS

No response

@ronso0 ronso0 added the bug label Apr 5, 2024
@ronso0 ronso0 changed the title Library: make BPM display and editing local consistent Library: make BPM display and editing locale consistent Apr 7, 2024
@daschuer
Copy link
Member

daschuer commented Apr 8, 2024

I can confirm that "128.002" is never a 128002.0 bpm.
So it is kind of nice if Mixxx to "correct" user input errors to a reasonable range. I support that idea.

@ronso0
Copy link
Member Author

ronso0 commented Apr 18, 2024

Fixed by #13067

allow both , and . in editor

addressed by #13068

@ronso0 ronso0 closed this as completed Apr 18, 2024
@ronso0 ronso0 added this to the 2.4.1 milestone Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants