Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing musicbrainz data for ripped WAV files causes track title to disappear #13014

Closed
ka2ddo opened this issue Mar 27, 2024 · 10 comments
Closed
Labels
bug incomplete stale Stale issues that haven't been updated for a long time.

Comments

@ka2ddo
Copy link

ka2ddo commented Mar 27, 2024

Bug Description

I ripped a CD with cdparanoia -B, and renamed the cdda.trackNN.wav files to names matching the actual track names, but without spaces (for example, 01-TurnMeOn.wav from my Kevin Lyttle CD).
I edited the properties of the track to change the track name to just the name (with spaces) and provide the artist and album names, then looked up the track in musicbrainz.
The track was found, but when I clicked the Apply and Close buttons on the Properties dialog, the track, artist, and album columns were blank for the track, and also blank in the Properties dialog when I reopened it. Stopping and restarting Mixxx caused the track to be reordered, but to still have blank track, artist, and album.
Yet the track could still be played with the correct music.

Version

built from source, latest main branch on 24 March 2024

OS

Raspbian bookworm, as of 24 March 2024, running on Pi400 hardware

@ka2ddo ka2ddo added the bug label Mar 27, 2024
@ronso0
Copy link
Member

ronso0 commented Mar 28, 2024

Maybe another version of #12963 which is fixed by #12965? (which still needs a review btw)

@ronso0
Copy link
Member

ronso0 commented Mar 28, 2024

@ka2ddo Can you try to reproduce with a build of #12965?

@ka2ddo
Copy link
Author

ka2ddo commented Mar 28, 2024

I couldn't find the branch mentioned in the other bug, but whatever was added to the main branch seemed to fix the problem when I 'git pull'd and rebuilt.

Thanks!

@ka2ddo ka2ddo closed this as completed Mar 28, 2024
@ka2ddo
Copy link
Author

ka2ddo commented Mar 28, 2024

No, that didn't fix it. But what did fix it was, after 'Apply' and 'Close' the musicbrainz sub-dialog, only clicking 'OK' in the main track properties dialog (instead of clicking 'Apply' and 'OK' like I had done previously).

So, it has a work-around.

@ka2ddo ka2ddo reopened this Mar 28, 2024
@daschuer daschuer added this to the 2.4.1 milestone Mar 28, 2024
@ronso0
Copy link
Member

ronso0 commented Mar 28, 2024

I couldn't find the branch mentioned in the other bug

It's a branch on my fork.
Easiest way to check it out is gh pr checkout 12965

@ronso0
Copy link
Member

ronso0 commented Mar 28, 2024

I'm not quite sure how to reproduce this.
Can you please list the actions you triggered as a list?

I tried

  • drag a new track into a deck, open Track Properties
  • click Metadata from MuscBrainz
  • new dialog is opened, track was found
  • select one of the results (dialog starts cover art fetching, done)
  • set "Tags" checkbox (unchecked by default)
  • hit Apply (tags are updated in Track Properties), hit Close

@ka2ddo
Copy link
Author

ka2ddo commented Mar 28, 2024

The exact sequence I used to foul it up was:

  1. Right-click on a track in the Library section of the screen, and pick "Properties" off the popup menu.
  2. In the track properties dialog, click the "Import Metadata from MusicBrainz" button.
  3. After it found the song in the DB, click on the correct source in the Metadata list, and click the "Apply" and "Close" buttons in the MusicBrainz dialog.
  4. Back at the track properties window, click the "Apply" button, then click the "OK" button (not just the "OK" button).

@ronso0
Copy link
Member

ronso0 commented Apr 8, 2024

I can not reproduce it.

Back at the track properties window, click the "Apply" button, then click the "OK" button (not just the "OK" button).

If you clicked Apply and Close in very quick succession (both call save()) and the metadata is cleared, then it might be #12963 which has been fixed by now.

If you can't reproduce it anymore with current main (or 2.4) please close this.

@daschuer daschuer modified the milestones: 2.4.1, 2.4.2 Apr 14, 2024
@daschuer
Copy link
Member

I can also not reproduce. However there is a misleading error Message "Could not find this track in the MusicBrainz database." in case the track file is no longer accessible due to renaming.
#13666

@daschuer daschuer removed this from the 2.4.2 milestone Sep 19, 2024
@github-actions github-actions bot added the stale Stale issues that haven't been updated for a long time. label Nov 19, 2024
Copy link

Expired for Mixxx because there has been no activity for 60 days.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug incomplete stale Stale issues that haven't been updated for a long time.
Projects
None yet
Development

No branches or pull requests

3 participants