Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playlist - count and totaltime not updated when adding a song #12761

Closed
Eve00000 opened this issue Feb 8, 2024 · 9 comments · Fixed by #12866
Closed

playlist - count and totaltime not updated when adding a song #12761

Eve00000 opened this issue Feb 8, 2024 · 9 comments · Fixed by #12866

Comments

@Eve00000
Copy link
Contributor

Eve00000 commented Feb 8, 2024

Bug Description

When adding a song to a playlist the playlist - count and -totaltime are not updated, both dragging song to playlist and right click.
After restart of Mixxx the counter and time are right.

extra, after de-selection (other song) and re-slecting song the playlist is bold (=song is in playlist)

Version

2.5-alpha-229-g7b3e48544a (main)

OS

Win 10

@Eve00000 Eve00000 added the bug label Feb 8, 2024
@ronso0
Copy link
Member

ronso0 commented Feb 9, 2024

Can confirm the playcount issue, repaint on selection change (bold) works though.

Crates are not affected, so it's probably some issue in PlaylistFeature::slotPlaylistTableChanged and/or PlaylistFeature::constructChildModel

@m0dB
Copy link
Contributor

m0dB commented Feb 23, 2024

(Thanks @ronso0 for spotting the duplicate bug report)

As I have been watching this behaviour closely while working on #12020 , I am sure this was working correctly not too long ago.

@m0dB m0dB added this to the 2.5-beta milestone Feb 23, 2024
@m0dB m0dB added regression and removed QT6 labels Feb 23, 2024
@m0dB
Copy link
Contributor

m0dB commented Feb 23, 2024

I am removing the Qt6 tag, as I am sure it worked correctly with Qt6, so I doubt it is Qt version related.

@ronso0
Copy link
Member

ronso0 commented Feb 23, 2024

Can confirm the playcount issue, repaint on selection change (bold) works though.

Crates are not affected, so it's probably some issue in PlaylistFeature::slotPlaylistTableChanged and/or PlaylistFeature::constructChildModel

or

QString PlaylistFeature::fetchPlaylistLabel(int playlistId) {

or there's an issue in PlaylistDAO.

@ronso0
Copy link
Member

ronso0 commented Feb 23, 2024

Damn, stupid typo 🤦‍♂️
8b79278

I'll push a fix asap

@ronso0
Copy link
Member

ronso0 commented Feb 23, 2024

but something else is wrong... I'll take a look.

@m0dB
Copy link
Contributor

m0dB commented Feb 23, 2024

Thanks for looking into this, @ronso0. If you get stuck, let me know; while I am certainly not an expert on this part of the code base, I have been looking at it quite a bit recently :-)

@Eve00000
Copy link
Contributor Author

Oh, there(s something going on here :-)
not as easy as you thought?

@ronso0
Copy link
Member

ronso0 commented Feb 23, 2024

I'm still not sure how this broke (currently bisecting), but a simple m_pSidebarModel->triggerRepaint() after updating the tree item label fixes it. Seems setting the label does not make the model emit dataChanged(index).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants