-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New GLSL waveforms are less detailed than legacy waveforms #12641
Comments
Looks mono, not stereo Edit: ah I see #11837 |
Related #11833 (comment) How shall we proceed here? |
Since the legacy waformsvate still there, this should not block the release. |
Are these top examples still with the curve that makes it look clipped when it's not? That's the only reason I can imagine it looks that inflated. It's like it lost a battle in the normalisation wars. Or is that new example current 2.5-alpha? Re colour, in the other issue, the fact that green never appears to be used is buggy to me. A skin with only waveforms n library would be good for comparisons. |
Both screenshots were taken with the (then) most recent 2.5/main builds |
I don't get it then, it literally looks clipped. That boost curve was removed, iirc, yes? If so, why then does it look normalised in the first example and clipped in the second? Edit: there's also a lot of headroom also, so that's confusing me too, but that could just be the track(?). |
It looks like this is impacting all waveforms with various degree of difference. Here is a video which might help to illustrate better these difference. Kooha-2024-05-08-18-15-40-10MB.mp4(Only the beginning is relevant, the rest is demo for PR #13220) |
have you tested with the texture PR? |
I haven't no, will try and merge the branch in mine and share a video when I can |
Here is a comparison with Kooha-2024-05-09-23-44-50.mp4 |
we really need to fix the gain issues with our waveforms, it makes direct comparison impossible. Either 2x everywhere or nowhere, not in some of them |
fyi I just noticed this as well (I wonder why I didn't earlier). I will try to find some time to look into this. |
I thought this was fixed with the textured/high detail waveforms? I'd be curious where you noticed any issues here Edit: Ah you probably mean the simple/filtered waveforms? |
Was the refactoring of the waveforms on main? IIRC the legacy waveforms got ported/rewritten and the menu was reorganized |
the settings refactoring yes. compiling right now to collect some up-to-date data. |
It is probably not that much effort to back port those changes to 2.5, and with very little risk. The preferences panel definitely is much clearer and mess less confusing for the user. What do you think, @acolombier? The question is, is it too late to do this? |
Tough one - I feel like it would be a bit late to be honest, and it is still 2k+ line changes. In the meantime, I do agree that there is a clear quality of life improvement here so cannot really make up my mind. |
Apart from the number of lines, do you think this can be done with some cherrypicks and some conflict resolution, or do you expect this to be more complicated? |
How about a middle ground: we could use the new nomenclature used in main but still use the current menu. |
As this is an additional wavefrm type, it is no regression. Therefore I see no reason for a last minute fix. |
I am ok with not getting this in to 2.5 |
Bug Description
Moving #12448 (comment) to a new issue here. Comparing the current GLSL waveforms:
to the legacy GLSL waveforms:
...there is a fair bit of detail missing in the new GLSL waveforms, especially the bass-heavy parts display more structure.
Version
2.5-alpha-207-g7ab184441d (HEAD)
OS
macOS 14.3
The text was updated successfully, but these errors were encountered: