Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

origins of effect Meta knob arcs are not consistent relative to their default positions #12634

Closed
nvdl opened this issue Jan 23, 2024 · 1 comment · Fixed by #12638
Closed

Comments

@nvdl
Copy link

nvdl commented Jan 23, 2024

Bug Description

Mixxx 2.4.0-beta
Git Version: 2.4-beta-347-gc323d0cd54
Platform: Linux x86_64
OS: Debian 11

Some knobs do not draw the delta ring relative to their default position.

Screenshot from 2024-01-23 20-06-51
Screenshot from 2024-01-23 20-07-18

"Echo", "Moog Filter" and "Balance" in the above shots do not draw the ring relative to the default (minimal/no-effect) position.

Version

No response

OS

No response

@nvdl nvdl added the bug label Jan 23, 2024
@ronso0 ronso0 changed the title Delta rings of knobs are not consistent relative to their default positions origins of effect Meta knob arcs are not consistent relative to their default positions Jan 23, 2024
@ronso0
Copy link
Member

ronso0 commented Jan 23, 2024

Yes, these are still dumb knobs currently. Arc origin is set in the skin (static) to either center, left or right.

To make them dynamic, i.e. aware of the effect's default Meta parameter we'd need to

  • add WEffectMetaKnob, derived from WKnobComposed
  • listen to EffectSlot::effectChanged in order to
  • get the manifest of the loaded effect, read & store default Meta parameter
  • adjust drawArc() to make use of it

Nice little weekend project for Mixxx 2.4.x : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants