Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixer > Main EQ > Graphic Equalizer isn't usable #12630

Open
idcmp opened this issue Jan 23, 2024 · 12 comments
Open

Mixer > Main EQ > Graphic Equalizer isn't usable #12630

idcmp opened this issue Jan 23, 2024 · 12 comments
Labels

Comments

@idcmp
Copy link

idcmp commented Jan 23, 2024

Bug Description

Apologies if this is fixed in a newer version.

image

  1. the yellow you see is the text from my crates in the main Mixxx window, somehow shining through the Preferences window.
  2. clicking on the circle in the slider will cause the EQ amount to jump wildly.
  3. clicking on a slider will cause other sliders to shift slightly (but the values stay the same).

The values change too violently to use this live to make adjustments. I can take a video snapshot if that helps.

Version

2.4-beta-328-gf610d58a25

OS

macOS arm64

@idcmp idcmp added the bug label Jan 23, 2024
@ronso0
Copy link
Member

ronso0 commented Jan 23, 2024

At least the opacity issue should have been fixed by #11647
Can you confirm the waveforms framerate slider and the end-of-track slider work as desired?
If yes, it may be that the fix from #11647 only applies to existing sliders (instantiated by the .ui files).
In contrast, the main EQ sliders are added on demand, when the effect settings are restored and when the main EQ effect is changed.
So maybe an update() or style()->polish() call solves the issue.

The other issues are new.

@ronso0
Copy link
Member

ronso0 commented Jan 23, 2024

Potential fix is #12631, please test!

@daschuer
Copy link
Member

daschuer commented Feb 1, 2024

Is this a regression compared to 2.3.6?

@daschuer
Copy link
Member

daschuer commented Feb 4, 2024

It is a regression compared to 2.3.6 and 2.5-alpha
Since we have no idea how to solve it, I have removed the experimental PRs from the 2.4 milestone. It will be fixed with the 2.5 release.

@fwcd
Copy link
Member

fwcd commented Feb 4, 2024

Seems to be a Qt 5 bug, I've added some notes here: #12711 (comment)

@daschuer daschuer added macos upstream This bug stems from an upstream issue labels Feb 5, 2024
@idcmp
Copy link
Author

idcmp commented Feb 21, 2024

@daschuer Running 1c6b44c (gh12630) (off of your fork), I still experience this problem.

@fwcd
Copy link
Member

fwcd commented Feb 21, 2024

That looks like a 2.4 build, which presumably still has the buggy Qt 5 version. We'll either have to patch Qt or you could try the 2.5 snapshots, which run Qt 6 and shouldn't have the issue.

@idcmp
Copy link
Author

idcmp commented Feb 21, 2024

Grabbed 2.5-alpha-250-gd21cb08ce3 (main)

Can confirm the Graphic Equalizer has gone from broken to just frustrating. (Which is an improvement!)

The knob is quite large, and it's almost impossible to click on the knob without causing the value to change, and it's not obvious how it will change when I click.

Infact, because the movement of the knob isn't 1:1 with the movement of my pointer on the screen, it's possible to click-and-drag, but then let go - and without moving my mouse - click again and cause the EQ knob to move.

@daschuer
Copy link
Member

Can you check out:
#12711

Does it make any difference? Are you able to build from source and merge this to the main branch? I am curious if this removes the "frustration" as well.

@idcmp
Copy link
Author

idcmp commented Feb 21, 2024

Unfortunately I don't have a dev toolchain installed on this Mac, and that's not an undertaking I have time for right now. If there's a PR-build I can download, I don't mind giving it a try though.

I will probably do it eventually as I need to remove "Add to AutoDJ (replace)" from the popup menu. 😭

@daschuer
Copy link
Member

I will probably do it eventually as I need to remove "Add to AutoDJ (replace)" from the popup menu. 😭

Can you file an issue for this? We may make it conditional via preferences or add a "really?" pop up.

@daschuer
Copy link
Member

Please test the Qt6 build you will find here: https://github.com/mixxxdj/mixxx/actions/runs/8001196736?pr=12862

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants