Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unwanted cover images from file system #12534

Open
ronso0 opened this issue Jan 9, 2024 · 1 comment
Open

Remove unwanted cover images from file system #12534

ronso0 opened this issue Jan 9, 2024 · 1 comment
Labels

Comments

@ronso0
Copy link
Member

ronso0 commented Jan 9, 2024

Bug Description

Detached from #12532

After manually clearing the auto applied cover art (which I do not want), the downloaded image is still in the filesystem and not removed.

Version

2.4

OS

No response

@ronso0 ronso0 added the bug label Jan 9, 2024
@ronso0
Copy link
Member Author

ronso0 commented Jan 9, 2024

There are these two cases how the image file was created:
1) the cover came with the music directory / was added manually by the users after the last library scan
2) cover was downloaded by Mixxx via Tag Fetcher
It is currently not possible to distinguish between 1 and 2.

For 2) this can only be implemeted by tracking the file operations while the Tag Fetcher dialog is still open, i.e. implicit undo/delete when a new cover is selected and applied.

For 1) Mixxx must not touch the image file without asking the user.
Furthermore, an image file may be referenced by other tracks. It's possible to check that, in case it's not we may offer to delete the image file.
This will get complex when removing the cover from multiple tracks via the context menu in the tracks table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant