Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset tapped BPM button #12209

Closed
axelkar opened this issue Oct 22, 2023 · 5 comments
Closed

Reset tapped BPM button #12209

axelkar opened this issue Oct 22, 2023 · 5 comments
Labels

Comments

@axelkar
Copy link

axelkar commented Oct 22, 2023

Feature Description

It is possible to right-click the track in the library and select Adjust BPM > Reset BPM but it's very inconvenient especially when someone accidentally taps the BPM button and doesn't know how to reset it.

Btw, can the GitHub discussion tab be enabled as the Zulip instance doesn't like my email server and I'd like to ask for help with some things related to the control object system?

@axelkar
Copy link
Author

axelkar commented Oct 22, 2023

Oh and what's the status on 2.4-alpha(?) vs 2.5 and the newest GitHub release 2.3.6?

@ronso0
Copy link
Member

ronso0 commented Oct 22, 2023

It is possible to right-click the track in the library and select Adjust BPM > Reset BPM

That is also available in the decks' track menu (right-click any track label).
Double-clicking the labels brings up the Track Properties which have a BPM tab with all related controls:
image

Additionally, there are Re-Ananlyze options in the track menu, either with constant or variable BPM.

I think we need to make the deck context menu more discoverable, and the first thing coming to mind is a simple hover effect, as used in #11755

Since I also a few times ran into this issue (accidentally set track BPM) I'm very much in favor of replacing the BPM tap button (set track BPM) with a rate tap button (tap playback speed), see #12104.

@ronso0
Copy link
Member

ronso0 commented Oct 22, 2023

Zulip instance doesn't like my email server

You can login with Github for example. Doesn't that work for you?

@axelkar
Copy link
Author

axelkar commented Oct 22, 2023

You can login with Github for example. Doesn't that work for you?

That worked! Thanks.

@ronso0
Copy link
Member

ronso0 commented Nov 2, 2023

very inconvenient especially when someone accidentally taps the BPM button

That is fixed by #12104.

This is the actual issue

I think we need to make the deck context menu more discoverable

so users find the Re-Analyze actions.
The hover effect I proposed can be applied to skins that have hover effects in other places.
I think some kind of Quick Start Guide, or tutorial (mini walkthrough) would be more helpful.

@ronso0 ronso0 closed this as completed Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants