Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waveform combobox looks cluttered #11915

Closed
daschuer opened this issue Sep 3, 2023 · 11 comments
Closed

Waveform combobox looks cluttered #11915

daschuer opened this issue Sep 3, 2023 · 11 comments

Comments

@daschuer
Copy link
Member

daschuer commented Sep 3, 2023

Bug Description

See:
grafik

There are to many words in braces

The non accelerated types are IMHO not legacy.

How is the state of discussion to drop legacy GLSL types?
Is "deprecated" a better word for the types that will be removed in the next version?

Version

2.4-beta

OS

No response

@ronso0
Copy link
Member

ronso0 commented Sep 3, 2023

We could group the types by (meta)type, and add plain separators, or non-selectable labels (e.g. "Deprecated:", "CPU-accelerated:")

@Holzhaus
Copy link
Member

Holzhaus commented Sep 3, 2023

Can't we only list the different waveforms (RGB, HSV, Filtered,...) and determine the proper rendering variant automatically depending on what is available? Most users have no idea what to select anyway.

@daschuer
Copy link
Member Author

daschuer commented Sep 4, 2023

For me, a minimal 2.4.0 solution is to get rid of the double (..) works:
RGB (GLSL)
RGB
RGB (legacy GL)
RGB (legacy GLSL)

The grouping idea sounds appealing. I would call CPU "accelerated" though. We may relpace GLSL by accelerated instead.

@Swiftb0y
Copy link
Member

Swiftb0y commented Sep 4, 2023

We're discussing polishing something that will be unnecessary by 2.5 anyways. Lets just keep as is to get the release out. This issue will resolve itself with the removal of the GL and GLSL types soon anyways.

@daschuer
Copy link
Member Author

daschuer commented Sep 4, 2023

But at least calling the non accelerated Waveforms legacy is wrong. We need an OKish user experience for 2.4 as well.

@Swiftb0y
Copy link
Member

Swiftb0y commented Sep 4, 2023

sure...

@ronso0
Copy link
Member

ronso0 commented Sep 4, 2023

As noted by others before, there are still way too many choices for beginners, and even advanced users I'd say. 🤪
A '?' hyperlink to a manual chapter with some (basic) explanation may be helpful (like the one for the Cue mode in Pref -> Decks).

Not sure if it's worth the effort for 2.4.x if we drop legacy waveforms in 2.5 anyway.

@daschuer
Copy link
Member Author

daschuer commented Sep 4, 2023

The mandatory part of this issue is now fixed. Do we want to close this or just remove or change the milestone?

@ronso0
Copy link
Member

ronso0 commented Sep 4, 2023

IMO polishing the list can happen anytime, so let's move it to 2.4.1 in case someone wants to take care of it.
(just don't want to dump the ideas I posted)

@acolombier
Copy link
Member

RGB (GLSL)
RGB
RGB (legacy GL)
RGB (legacy GLSL)

Are we okay to only display the "best" rendering backend available so we can remove the (..) entirely? Perhaps list them all if --developer is passed, like for the VSyncTest?

@daschuer
Copy link
Member Author

daschuer commented Apr 14, 2024

Oh, I just have noticed this is only about the appearance of each string. This has already be resolved in 2.4.0

@daschuer daschuer removed this from the 2.4.1 milestone Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants