Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waveforms dissapear after window resized #11460

Closed
philwilkinson opened this issue Apr 9, 2023 · 11 comments · Fixed by #10989
Closed

Waveforms dissapear after window resized #11460

philwilkinson opened this issue Apr 9, 2023 · 11 comments · Fixed by #10989

Comments

@philwilkinson
Copy link

Hi, on my M2 mac the waveform is visible (in all themes that show it). But as I resize the window or make it full screen the waveform is replaced by a white background. The vertical grid lines and markers are visible. Resizing it smaller and the waveform re-appears.

image

This is for Mixxx 2.3.4 on MacOs Ventura 13.3.1, on a M2 Macbook Pro.

@daschuer
Copy link
Member

daschuer commented Apr 9, 2023

Has this issue happened on 2.3.3 before?

@philwilkinson
Copy link
Author

The same thing happens in 2.3.3.
However the problem only happens when I put mixxx on any of my 2 4k external displays at the medium scale (medium text) setting to smallest scale (smaller text) setting AND the laptop is closed (operating in camshell mode), so the built in display is off.
If open the laptop, so the laptop screen is displaying, mixxx on the other 4k screen seems to get sorted out, in that there is no white background, however, when i close the laptop again, the right side of the wave form isn't displayed on the 4k monitor!
The laptops built in display has no problem displaying waveforms in mixxx, even at the smallest scale (smaller text) setting (although the laptop resolution is less than 4k).

@daschuer
Copy link
Member

Are all waveform types affected? Do you see issues whit the spinnies or Vu-Meters during resizting?
Are loop markers and the end of track warning still there?

@philwilkinson
Copy link
Author

I tried many combinations of Waveform type and Waveform overview type, and sometimes they would work and sometimes they wouldn't, there was no consistent combination that always worked.

The default is RGB (GLSL) - RGB - This shows blank white initially.
If I change to RGB (GL) - RGB - It worked fine.
Changing to RGB (GL) - HSV - It went blank white.
back to RGB (GL) - RGB - its still blank white.

There are no issues with the spinnies and the VU meters (which don't resize) and the loop and end of track markers also visible always.

@m0dB
Copy link
Contributor

m0dB commented May 28, 2023

@philwilkinson could you try with the macOS arm64 build from this page

https://github.com/mixxxdj/mixxx/actions/runs/5098639997?pr=10989

and select one of the (allshaders) waveform types.

@philwilkinson
Copy link
Author

Thanks @m0dB

It works for...
Filtered (GL), Filtered (all shaders) (GLSL) , RGB (GL), RGB (all-shaders) (GLSL), RBG L/R (all-shaders) (GLSL), Simple (GL), Simple (all-shaders) (GLSL)

It doesn't work (still get blank white background) for...
Filtered (GLSL), RGB (GLSL), RGB Stacked (GLSL)

The result is the same for RGB,HSV and Filtered waveform overview type.
I hope this is what you expected.

@JoergAtGithub
Copy link
Member

JoergAtGithub commented May 28, 2023

The result is the same for RGB,HSV and Filtered waveform overview type.

Can you please elaborate this - because the implementation of the Overview Waveforms has no technical relationship to the Waveform implementation.

@philwilkinson
Copy link
Author

philwilkinson commented May 28, 2023

Hi, yes sure, in the release build the combination of Waveform type and Waveform overview type, effected in a inconsistent way, whether or not the waveforms were rendered correctly - at least that's how it appeared to me.

With this build only selecting the Waveform type effects it working or not.

Filtered (GLSL), RGB (GLSL), RGB Stacked (GLSL) don't work, the rest do.

Heres an example of it not working for RGB Stacked (GLSL)
image

@m0dB
Copy link
Contributor

m0dB commented May 28, 2023

Thanks for testing, @philwilkinson . Nice to hear the new "(all-shaders)" waveform types are working correctly. Our intention is that this (#10989) will be part of the 2.4 release, so that should solve your issue (which is pretty strange!)

@philwilkinson
Copy link
Author

Great, thanks, so I guess this issue can be closed then as I can see that It'll work fine for all-shaders. Cheers.

@JoergAtGithub
Copy link
Member

Fixed by #10989

@daschuer daschuer added this to the 2.4.0 milestone Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants