Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make tracks view wrap-around less surprising #11276

Open
ronso0 opened this issue Feb 14, 2023 · 0 comments
Open

make tracks view wrap-around less surprising #11276

ronso0 opened this issue Feb 14, 2023 · 0 comments
Labels

Comments

@ronso0
Copy link
Member

ronso0 commented Feb 14, 2023

Feature Description

#11090 added wrap-around to the tracks view when it is navigated with either Up/Down keys or with a controller.
As helpful as this, for example when having the tracks sorted by key, I find it usually surprising / confusing because there's no clear feedback when approaching the top/bottom of the list.

So far two helpers came to mind:

  1. delay the wraparound 524cbc7
    when pressing Up/Down repeatedly, require a keypress pause of 1 second before wrapping around. 1 second is just a guess, will probably adjust that after testing with my controller.
    also, this can be adjusted to work with one timer, but

  2. show more surrounding lines (3) when moving 9d39314
    Applied for Up, Down, PageUp & PageDown.
    With that, there's more context and the wrap-around is to be expected when the cursor moves to the first/last row.

For now, these two commits combined work fine for me. If anyone wants to polish it, for example make the number of lines above/below depend on the total of visible lines, feel free to cherry-pick these commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant