Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation wraparound in library tracks list #11088

Closed
robbert-vdh opened this issue Nov 23, 2022 · 3 comments
Closed

Navigation wraparound in library tracks list #11088

robbert-vdh opened this issue Nov 23, 2022 · 3 comments

Comments

@robbert-vdh
Copy link
Contributor

Feature Description

I just started using Mixxx and I'm seriously impressed by how well it works. One thing I did notice was that there is no wraparound in the library. When browsing a collection of tracks sorted by key (which Mixxx sorts according to the circle of fifths, awesome), you can't easily go from the end of the list back to the beginning or the other way around without reaching for a mouse or keyboard.

Is this desirable behavior? I can submit a PR, but I thought I'd ask first. This would make navigating the library with a controller much better especially when sorting by key. I did see some reference to this in the library implementation already. If this behavior was previously deemed to be confusing, could it maybe just become an option in the preferences?

@daschuer
Copy link
Member

Yes, it does make sense in case of sorting by key. I think we need to do some usability test to find the sweet spot between annoying and useful. A preferences option should be the last resort.
Go ahead if you have interest ti implement this.
Here some general hints: https://github.com/mixxxdj/mixxx/wiki/Bugfix-Workflow

@poelzi
Copy link
Contributor

poelzi commented Nov 24, 2022

I implemented this at my library rework, guess this got lost when the branch was updated to master.

@robbert-vdh
Copy link
Contributor Author

Oh I hadn't seen that. #11090 adds it back to both the [Library],MoveVertical action that can be mapped to controllers and cursor key navigation (without breaking support for shift/ctrl+cursor keys). And anything else that relies on moveCursor().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants