Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEBUG ASSERT: "hintFrameCount >= 0" in function void CachingReader::hintAndMaybeWake(const HintVector&) at src/engine/cachingreader/cachingreader.cpp:535 #10556

Closed
mixxxbot opened this issue Aug 23, 2022 · 5 comments

Comments

@mixxxbot
Copy link
Collaborator

Reported by: Holzhaus
Date: 2021-10-12T13:47:22Z
Status: Fix Committed
Importance: High
Launchpad Issue: lp1946759
Tags: engine, looping


When setting a beatloop in front of the actual track (i.e. so that the end of the loop is before the first audio frame), the following debug assertion will be triggered:

    DEBUG ASSERT: "hintFrameCount >= 0" in function void CachingReader::hintAndMaybeWake(const HintVector&) at src/engine/cachingreader/cachingreader.cpp:535

Steps to reproduce:

  1. Go to the beginning of the track
  2. Use beatjump to go to 8 beats before the beginning of the track
  3. Set a Beatloop of 4 beats
  4. DEBUG_ASSERT is triggered
@mixxxbot
Copy link
Collaborator Author

Commented by: Holzhaus
Date: 2021-10-12T13:54:42Z


2.3 seems to be unaffected, but I can reproduce this 100% of the time on 2.4-alpha-880-g7b22498e81.

@mixxxbot
Copy link
Collaborator Author

Commented by: Holzhaus
Date: 2021-10-12T14:05:22Z


Looks like the assertion was introduced by 8589930 (#⁠1223). In 7d96c38 (#⁠3081, part of 2.3) I fixed a condition where the assertion was no longer true and hintFrameCount might be 0.

It looks like main now also makes it possible for negative values to occur?

@mixxxbot
Copy link
Collaborator Author

Commented by: Holzhaus
Date: 2021-10-12T14:21:45Z


Also happens when using the loop in/out buttons instead of beatloops.

@mixxxbot
Copy link
Collaborator Author

Commented by: Holzhaus
Date: 2021-10-12T14:33:34Z


#4383

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Committed.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.4.0 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant