-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows display scaling factors 125% + 175% are not applied correctly #10485
Comments
Commented by: mirh |
Commented by: Be-ing Mixxx uses the OS's scaling setting. What is the problem? |
Commented by: ronso0 A screenshot of a native windows app (Notepad?) would help us to compare the scaling. |
Commented by: mirh You are absolutely right. I just tested 150% and 200% scaling and they work. I just tested QT_SCALE_FACTOR=1.25 though, and that didn't have problems. |
Commented by: Be-ing This is likely Qt trying to be too clever with rounding the scale factor... |
Commented by: ronso0 maybe QT_SCALE_FACTOR_ROUNDING_POLICY |
Commented by: mirh You are spot on EDIT: interestingly enough, while QT_SCALE_FACTOR_ROUNDING_POLICY=PassThrough managed to also do most of the trick, it neglected the size of the library fonts. |
Commented by: Holzhaus We could use https://doc.qt.io/qt-5/qt.html#HighDpiScaleFactorRoundingPolicy-enum if we switched to Qt 5.14. |
Commented by: mirh I'm saying that forcing the scale factor still had an overall marginally better looking experience than the rounding policy. Also, it is my understanding from the linked commits above that all platforms should be affected.. It's just that probably nobody has high hidpi expectations on linux /s |
Commented by: Be-ing
We are already using Qt 5.15.2 on Windows. It is only macOS where we are stuck with Qt 5.12. |
Commented by: Be-ing mirh, could you test setting the environment variable QT_SCALE_FACTOR_ROUNDING_POLICY=PassThrough before starting Mixxx from a command prompt? If this works well without odd looking artifacts we may consider setting the rounding policy to passthrough by default. |
Commented by: ronso0
If we intend to fix this in a 2.3 point release it's not applicable to Ubuntu 20.04 builds because those are still using 5.12.8 |
Commented by: Be-ing That only affects Ubuntu LTS users. Other Linux distros are not stuck on Qt 5.12. |
Commented by: Holzhaus I propose to add the fix inside a QT_VERSION_CHECK. People using Ubuntu will have to live with the current scaling behavior, but it's actually a good thing. Stable distros are for users that don't want their system to change without a distro upgrade, so fixing the bug would be confusing and might break their workflows :D. |
Commented by: ronso0 I can't turn on the CPU fan with spacebar anymore :D |
Commented by: Be-ing Yes, a QT_VERSION_CHECK is needed because Mixxx 2.3 still supports Qt 5.12. |
Commented by: Holzhaus
Context: https://xkcd.com/1172/ |
Issue closed with status Fix Released. |
Reported by: mirh
Date: 2021-07-27T00:16:46Z
Status: Fix Released
Importance: Medium
Launchpad Issue: lp1938102
Attachments: [Screenshot from a 27" 2560x1440 monitor](https://bugs.launchpad.net/bugs/1938102/+attachment/5513914/+files/Screenshot from a 27" 2560x1440 monitor)
At least on Windows it's pretty awfully small.
The text was updated successfully, but these errors were encountered: